[MGNLSTK-1453] Do not allow selection of invalid redirection targets Created: 19/Dec/14 Updated: 20/Jan/16 Resolved: 04/May/15 |
|
| Status: | Closed |
| Project: | Magnolia Standard Templating Kit (closed) |
| Component/s: | templates |
| Affects Version/s: | 2.8.6 |
| Fix Version/s: | 2.8.9 |
| Type: | Bug | Priority: | Major |
| Reporter: | Lars Fischer | Assignee: | Christoph Meier |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | stk, support, uzh, validation | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | Not Specified | Time Spent: | Not Specified |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Issue Links: |
|
||||||||||
| Sub-Tasks: |
|
||||||||||
| Template: |
|
||||||||||
| Acceptance criteria: |
Empty
|
||||||||||
| Date of First Response: | |||||||||||
| Description |
|
The current stkRedirect template dialog does not validate the selected target path for redirection. So it's possible to select the redirect page itself as target for redirection. This could cause an infinite loop problem. The template dialog should validate if the selected path is different than the path of the current page. |
| Comments |
| Comment by Magnolia International [ 08/Apr/15 ] |
|
What if the target is another page, which is itself also a redirect, and the target of the latter is the page you're currently editing ? |
| Comment by Christoph Meier [ 24/Apr/15 ] |
|
All commits are on branch " |
| Comment by Christoph Meier [ 24/Apr/15 ] |
|
The validator assumes that both nodes current page and target page are both on website repository (which also indicates unique node paths) and considers the redirect path as invalid, if: |
| Comment by Philip Mundt [ 28/Apr/15 ] |
|
Small things only:
|
| Comment by Christoph Meier [ 28/Apr/15 ] |
|
Re-resolved according to review comments. |
| Comment by Christopher Zimmermann [ 30/Apr/15 ] |
|
Please integate on 2.9 branch. |