[MGNLSTK-1490] Remove STK-bundle, refactor STK modules dependencies Created: 07/Jul/15  Updated: 11/Aug/15  Resolved: 31/Jul/15

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: bundle
Affects Version/s: 2.9
Fix Version/s: 2.9.1

Type: Task Priority: Neutral
Reporter: Mikaël Geljić Assignee: Evzen Fochr
Resolution: Fixed Votes: 0
Labels: 54qa
Remaining Estimate: 0d
Time Spent: 3d 1h 10m
Original Estimate: Not Specified

Issue Links:
Relates
relates to MAGNOLIA-6154 Revise CE bundle's dependencies Closed
dependency
depends upon MGNLRES-182 Cleanup dependencies in resources mod... Closed
depends upon MGNLFORM-268 Refactoring form module pom Closed
depends upon MGNLPUR-158 Refactoring pur module pom Closed
relation
is related to MGNLSTK-1495 Replace STK own pagination with one p... Closed
is related to MGNLPUR-160 Remove PUR bundle Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Sprint: Sprint 3 (Kromeriz)
Story Points: 5

 Description   

Remove bundle from STK project.
Refactor dependencies in STK modules using

mvn dependency:tree

and

mvn dependency:analyze


 Comments   
Comment by Mikaël Geljić [ 07/Jul/15 ]

For what it's worth, building that bundle (guess-what) at ce-bundle level would benefit from dependencyManagement there. And maybe provide those artifacts as add-ons? (or same as EE, bundles with and without addons).

Comment by Evzen Fochr [ 21/Jul/15 ]

Many dependencies are brought by magnolia-resources and magnolia-module-inplace-templating modules.

Comment by Milan Divilek [ 28/Jul/15 ]

Reopen:

Add exclusion of <groupId>info.magnolia.core</groupId> - <artifactId>magnolia-resource-loader</artifactId> into <groupId>info.magnolia</groupId> - <artifactId>magnolia-module-standard-templating-kit</artifactId> in bundle pom

<!-- dependency of Forum-> and <!- dependency of Form and PUR--> from bundle pom should go into poms where Forum, Form and PUR dependencies are defined

Comment by Philip Mundt [ 28/Jul/15 ]

Why are we raising dependencies according to the changelog? I know it might make sense from a stk-bundle-perspective, but e.g. the raise of DAM dep. to 2.1.1-SNAPSHOT is not necessary (there is not actualy code change in DAM).

Comment by Magnolia International [ 28/Jul/15 ]

A lot of dependencies have been added that are completely unnecessary (imageinfo in theme-pop !?); exclusions have then been added to circumvent more transitive dependencies.
In general, dependency:tree and dependency:analyze provide a lot of good insights. Do not hesitate to remove (or at least question!) dependencies that exist but aren't justified (maybe there is a reason for demo-project to depend on dam-app, but that should be commented !)

Comment by Evzen Fochr [ 29/Jul/15 ]

Dependency on dam-app was added because of dependency:analyze. "imageinfo" is not needed anymore after integrating MGNLRES-182, thx for tip.

Comment by Philip Mundt [ 29/Jul/15 ]

In https://git.magnolia-cms.com/gitweb/?p=modules/standard-templating-kit.git;a=commitdiff;h=7ee8735125c96ec69cd86a2c6eabc6296b0e15a6 you removed the dependency to data (STK was actually bringing it in). This is now causing a migration diff: https://jenkins.magnolia-cms.com/job/int_migration-tests_4.5-to-5.4.x-branch-cms/
Edit: same goes for https://jenkins.magnolia-cms.com/job/int_migration-tests_5.3-to-5.4.x-branch-cms/

Comment by Magnolia International [ 29/Jul/15 ]

Have a look at [new branch] fix/MGNLSTK-1490-bundle-dependencies – it's not perfect yet (I don't think we need all of dam in there), but IMO much cleaner.

Comment by Evzen Fochr [ 29/Jul/15 ]

It was decided to remove bundle from STK module.
http://git.magnolia-cms.com/gitweb/?p=modules/standard-templating-kit.git;a=shortlog;h=refs/heads/MGNLSTK-1490-remove-bundle

Generated at Mon Feb 12 07:37:04 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.