[MGNLSTK-1490] Remove STK-bundle, refactor STK modules dependencies Created: 07/Jul/15 Updated: 11/Aug/15 Resolved: 31/Jul/15 |
|
| Status: | Closed |
| Project: | Magnolia Standard Templating Kit (closed) |
| Component/s: | bundle |
| Affects Version/s: | 2.9 |
| Fix Version/s: | 2.9.1 |
| Type: | Task | Priority: | Neutral |
| Reporter: | Mikaël Geljić | Assignee: | Evzen Fochr |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | 54qa | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 3d 1h 10m | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||
| Task DoR: |
Empty
|
||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||
| Sprint: | Sprint 3 (Kromeriz) | ||||||||||||||||||||||||||||||||||||
| Story Points: | 5 | ||||||||||||||||||||||||||||||||||||
| Description |
|
Remove bundle from STK project. mvn dependency:tree and mvn dependency:analyze |
| Comments |
| Comment by Mikaël Geljić [ 07/Jul/15 ] |
|
For what it's worth, building that bundle (guess-what) at ce-bundle level would benefit from dependencyManagement there. And maybe provide those artifacts as add-ons? (or same as EE, bundles with and without addons). |
| Comment by Evzen Fochr [ 21/Jul/15 ] |
|
Many dependencies are brought by magnolia-resources and magnolia-module-inplace-templating modules. |
| Comment by Milan Divilek [ 28/Jul/15 ] |
|
Reopen: Add exclusion of <groupId>info.magnolia.core</groupId> - <artifactId>magnolia-resource-loader</artifactId> into <groupId>info.magnolia</groupId> - <artifactId>magnolia-module-standard-templating-kit</artifactId> in bundle pom <!-- dependency of Forum- |
| Comment by Philip Mundt [ 28/Jul/15 ] |
|
Why are we raising dependencies according to the changelog? I know it might make sense from a stk-bundle-perspective, but e.g. the raise of DAM dep. to 2.1.1-SNAPSHOT is not necessary (there is not actualy code change in DAM). |
| Comment by Magnolia International [ 28/Jul/15 ] |
|
A lot of dependencies have been added that are completely unnecessary (imageinfo in theme-pop !?); exclusions have then been added to circumvent more transitive dependencies. |
| Comment by Evzen Fochr [ 29/Jul/15 ] |
|
Dependency on dam-app was added because of dependency:analyze. "imageinfo" is not needed anymore after integrating |
| Comment by Philip Mundt [ 29/Jul/15 ] |
|
In https://git.magnolia-cms.com/gitweb/?p=modules/standard-templating-kit.git;a=commitdiff;h=7ee8735125c96ec69cd86a2c6eabc6296b0e15a6 you removed the dependency to data (STK was actually bringing it in). This is now causing a migration diff: https://jenkins.magnolia-cms.com/job/int_migration-tests_4.5-to-5.4.x-branch-cms/ |
| Comment by Magnolia International [ 29/Jul/15 ] |
|
Have a look at [new branch] fix/ |
| Comment by Evzen Fochr [ 29/Jul/15 ] |
|
It was decided to remove bundle from STK module. |