[MGNLSTK-1518] Replace themes app in STK with one from site module Created: 17/Dec/15  Updated: 15/Jan/16  Resolved: 13/Jan/16

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 2.9.3

Type: Task Priority: Neutral
Reporter: Oanh Thai Hoang Assignee: Sang Ngo Huu
Resolution: Fixed Votes: 1
Labels: site, theme
Remaining Estimate: 5h 40m
Time Spent: 2d 2h 20m
Original Estimate: 3d

Issue Links:
Cloners
clones MGNLSITE-28 Provide an app to CRUD themes Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Sprint: Saigon 26
Story Points: 5

 Description   

STK used to have an app to manage themes. This app will now be provided by the Site module (See MGNLSITE-28).

This ticket covers the consequences on STK module:

  • STK's "Themes" app will be removed from the app-launcher, as a first step
  • STK's "Site Definitions" app will be removed from the app-launcher, as a first step
  • ThemeInstallTask and ThemeVersionHandler (and other potential theme support classes) will be deprecated/relocated to site module


 Comments   
Comment by Mikaël Geljić [ 12/Jan/16 ]

Missing removal of those apps upon fresh install, migration diff around the corner (unless I missed something)
EDIT: pushed candidate fix to PR

Comment by Mikaël Geljić [ 13/Jan/16 ]

As mentioned by sang.ngo, my patch commit doesn't only remove legacy stkSites/stkThemes apps from applauncher config (like upgrade does), but it removes their config entirely.
This was agreed upon, because for fresh installs, nobody will have used those apps before, and site-app module provides the replacement app.

We will ignore this diff explicitly in migration-tests.

Generated at Mon Feb 12 07:37:20 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.