[MGNLSTK-1521] Allow RedirectTargetValidator to consume external links Created: 20/Jan/16  Updated: 11/Mar/16  Resolved: 10/Mar/16

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: None
Affects Version/s: 2.8.9
Fix Version/s: 2.8.11, 2.9.4

Type: Bug Priority: Neutral
Reporter: Zdenek Skodik Assignee: Christoph Meier
Resolution: Fixed Votes: 0
Labels: support
Remaining Estimate: 0d
Time Spent: 1d 1.5h
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLSTK-1453 Do not allow selection of invalid red... Closed
Template:
Acceptance criteria:
Empty
Date of First Response:
Sprint: Basel 34
Story Points: 3

 Description   

So that it's inline with business logic of stkRedirect template.



 Comments   
Comment by Christoph Meier [ 09/Mar/16 ]

The redirect target has just one field (and a checkbox) - there is no input to indicate wether the value is for an internal or an external link, the script will figure it out.
When adding an external link - it can be done with or without protocol. This makes it a bit tricky to figure out in the validator whether the link is internal or external.

RedirectTargetValidator considers a link as external if it is not starting with "/". If that's the case - an external link is not further examined and validation passes.

Comment by Federico Grilli [ 11/Mar/16 ]

QAed on both 5.3.x and 5.4.x

Generated at Mon Feb 12 07:37:22 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.