[MGNLSTK-401] showbox: various improvments Created: 16/Jun/09  Updated: 23/Jan/13  Resolved: 06/Jul/09

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 1.1.1

Type: Improvement Priority: Major
Reporter: Philipp Bärfuss Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLSTK-410 Should CSS react on last/first image ... Sub-task Closed Christian Ringele  
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Date of First Response:

 Description   

Here a quick summary about what we discussed together on the
telephone regarding the showbox, and the 'consolidation' of it with
Boris for STK.
In the showbox the following should implemented/changed:

  • Closing showbox on key escape
  • Going to the previous/next image over the keyboard arrows too (not
    only the href's of prev/next).
  • Clicking besides the showbox onto the grey scaled background/
    origin page, the showbox should close.
  • When no previous or next image is available, the pre/next should
    not appear. Best would be if no href would be generated at all, if
    no next/ prev is available.


 Comments   
Comment by Philipp Bärfuss [ 16/Jun/09 ]

Please update tools-n-showbox.js

Comment by Christian Ringele [ 16/Jun/09 ]

Is checked in: Revision 26246

Comment by Christian Ringele [ 16/Jun/09 ]

This point is still open.

  • When no previous or next image is available, the pre/next should
    not appear. Best would be if no href would be generated at all, if
    no next/ prev is available.

With the new JS which is checked in, a previous/next image which is not available the class is marked 'prev disabled' or 'next disabled'.
A solution on how the css should react on it is needed.

Comment by Christian Ringele [ 17/Jun/09 ]

I define the point above a bit more in detail:

With the behaviour of 'prev disabled' and 'next disabled' i could react in a project accordingly in css.
There the need was different.

In stk it should be decided, if the CSS should react and how.
Possibilities is see, but Aperto has to define if this is possible, makes sence:

  • When only one image is shown, no next/prev arrows are shown at all.
  • When no next or prev is available, probably the arrow and the 'prevoius' could be replaced by a transparent image with the same size.
    Like this the arrow would not be visible anymore. But i could imagine, that this is not possible in a proper way, that it looks fine.
  • Could be left as it is.
Comment by Christian Ringele [ 06/Jul/09 ]

In showbox this was implemented:

  • Showbox closes on key 'esc'
  • Showbox can be navigated with arrow keys
  • JS reacts on first/last element of the showbox -> css class adapts from 'prev' to 'prev disabled'

CSS itself does not react yet on this adaption, the question above remains open -> sub task created and closed this main task.

Generated at Mon Feb 12 07:26:40 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.