[MGNLSTK-441] BodyClass 'col' has to be overworked Created: 20/Aug/09  Updated: 23/Jan/13  Resolved: 04/Sep/09

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: concept
Affects Version/s: 1.1.1
Fix Version/s: 1.2

Type: Bug Priority: Major
Reporter: Christian Ringele Assignee: Christian Ringele
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLSTK-452 css: should support the body class 'col' Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

For the possibility of displaying mainArea content over the complete width of a page a bodyClass 'col' was implemented into the BodyClassResolver.java.
'col' would mean, that the V-Navigation&extrasArea&promosAre are disabled.

Now there are two problems about this col:
1. 'col' bodyClass is not defined yet in the css. When a page gets rendered with col, the mainArea width is very small (like on nav-col-subcol).
2. When V-Navigation is active, but does not show yet because the depth of the page is to high, the bodyClass resolved is 'col' in stead of 'nav-col'.
Only when the V_Navigation is really deactivated it should render 'col'.
For example: Configuring the H-Navigation with two levels. Adding page HomePage-SectionPage-SiteMap
The SiteMap page is displayed on H-Navigation level 2 -> no V-Navigation is rendered. But the bodyClass should remain 'nav-col' for having the space of navigation at the left side. Before implementing the 'col', this was at least the standard behavior of all pages -> leaving at the left side the space for navigation as long the navigation is not generally (or on specific template) deactivated.

I thing the concept of 'col' and 'nav-col' (and eg 'col-subcol' to 'nav-col-subcol' should be looked at and be clearly defined and implemented into css.



 Comments   
Comment by Philipp Bärfuss [ 21/Aug/09 ]

The body class reflects the current situation and not the site configuration. If you have after level 3 a sub-navigation but your page exists on level 2 it won't render a navigation and the correct body class is: col, respectively col-subcol. Otherwise the demo project would simply not work. The effect would be that on the section pages empty space would be added in the left side.

So the only 'open' point is that this is not supported by the CSS. But in case you need it you can simply adapt the CSS accordingly.

Comment by Christian Ringele [ 21/Aug/09 ]

You are right, its on the current situation and not the configuration.
I had that wrong in my mind...

About the css:
The problem there is, that as soon as you disable extras in siteConfiguration, most pages on top level get an 'col'.
this because they don't contain a V-Navigation.

Originally the idea of 'col' was, that mainContent is spread across the complete page. This more regarding content pages.
I don't know if this behavior is not contradicting to the bodyClass concept of aperto because it applies mainly to top level hierarchies, which are mostly sections.

Comment by Philipp Bärfuss [ 04/Sep/09 ]

Is kind of succeeded by MGNLSTK-452

Generated at Mon Feb 12 07:27:04 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.