[MGNLSTK-494] Files from theme can differ in the file extension and will still be installed Created: 29/Oct/09 Updated: 18/Jul/14 Resolved: 18/Jul/14 |
|
| Status: | Closed |
| Project: | Magnolia Standard Templating Kit (closed) |
| Component/s: | themepop, update |
| Affects Version/s: | 2.7.5, 2.8 |
| Fix Version/s: | 2.7.6, 2.8.2 |
| Type: | Bug | Priority: | Major |
| Reporter: | Rainer Blumenthal | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | support | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||
| Description |
|
If you have 2 images in your theme "icon.jpg" + "icon.gif" the ThemeUpdateHandler - there is only one entry for those 2 files in DMS... The differing extension is not used - you have to rename right now. |
| Comments |
| Comment by Magnolia International [ 04/May/10 ] |
|
Also (more) likely to happen with files such as myTheme.js + myTheme.css |
| Comment by Magnolia International [ 02/Jun/14 ] |
|
Eh - better late than never - my comment above isn't exactly relevant, since ThemeInstallTask expects js and css files to be in different folders anyway. |
| Comment by Roman Kovařík [ 13/Jun/14 ] |
|
We could probably use extension handling provided by http://jira.magnolia-cms.com/browse/MGNLRES-104?focusedCommentId=81390&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-81390 , see point 4 of the comment. |
| Comment by Christopher Zimmermann [ 17/Jul/14 ] |
|
Technically - the fix "works" It is possible for a ThemeVersionHandler to override getExtraInstallTasks and getDefaultUpdateTasks in order to call ThemeInstallTask(x, false). I would consider it closed if:
|
| Comment by Philip Mundt [ 18/Jul/14 ] |
|