[MGNLSTK-494] Files from theme can differ in the file extension and will still be installed Created: 29/Oct/09  Updated: 18/Jul/14  Resolved: 18/Jul/14

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: themepop, update
Affects Version/s: 2.7.5, 2.8
Fix Version/s: 2.7.6, 2.8.2

Type: Bug Priority: Major
Reporter: Rainer Blumenthal Assignee: Roman Kovařík
Resolution: Fixed Votes: 1
Labels: support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLSTK-1405 Change default behavior of ThemeVersi... Closed
relates to DOCU-527 Add details about new features of Ins... Closed
causality
dependency
depends upon MGNLRES-104 Extension field missing: The extensio... Closed
depends upon MGNLRES-113 Install(Text/Binary)ResourcesTask doe... Closed
Template:
Acceptance criteria:
Empty
Release notes required:
Yes
Date of First Response:

 Description   

If you have 2 images in your theme "icon.jpg" + "icon.gif" the ThemeUpdateHandler - there is only one entry for those 2 files in DMS...

The differing extension is not used - you have to rename right now.



 Comments   
Comment by Magnolia International [ 04/May/10 ]

Also (more) likely to happen with files such as myTheme.js + myTheme.css

Comment by Magnolia International [ 02/Jun/14 ]

Eh - better late than never - my comment above isn't exactly relevant, since ThemeInstallTask expects js and css files to be in different folders anyway.

Comment by Roman Kovařík [ 13/Jun/14 ]

We could probably use extension handling provided by http://jira.magnolia-cms.com/browse/MGNLRES-104?focusedCommentId=81390&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-81390 , see point 4 of the comment.

Comment by Christopher Zimmermann [ 17/Jul/14 ]

Technically - the fix "works" It is possible for a ThemeVersionHandler to override getExtraInstallTasks and getDefaultUpdateTasks in order to call ThemeInstallTask(x, false).
However I am re-opening ticket because the default case is still that "Files from theme that only differ in the file extension don't work".

I would consider it closed if:

  • The ticket name was changed - maybe like "Files from theme CAN differ..."
  • A follow-up ticket for a major release to change the DEFAULT behaviour of ThemeVersionHandler - probably with some kind fo configuration option to protect existing installations from having all their resource files renamed.
  • A comment or documentation is included how to override a ThemeVersionHandler in order to perform this correctly.
Comment by Philip Mundt [ 18/Jul/14 ]
  • Created a follow-up ticket, to enable this feature by default in the next major version: MGNLSTK-1405
  • Added a documentation-request: DOCU-527
  • Renamed this ticket accordingly
Generated at Mon Feb 12 07:27:34 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.