[MGNLSTK-500] The horizontal menu cannot be localized due to a hardcoded String in LinkImpl Created: 05/Nov/09  Updated: 23/Jan/13  Resolved: 08/Nov/09

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: base system
Affects Version/s: 1.1
Fix Version/s: 1.2

Type: Bug Priority: Major
Reporter: Ron de Ridder Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: i18n
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File LinkImpl.java.patch    
Issue Links:
dependency
depends upon MAGNOLIA-2931 templating: the renderer should not o... Closed
supersession
is superseded by MGNLSTK-552 I18n does not work for the Navigation Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

The menu in STK uses the navigationTitle property to store the text to show in the menu. I am using localisation in Magnolia and I noticed that this text could not be translated with adding the locale to the end of the property, for example: navigationTitle_de. When attaching a debugger I found that "navigationTitle" is hardcoded into info.magnolia.module.templatingkit.navigation.LinkTitle. See the code snippet below.

public String getNavigationTitle(){
String navigationTitle = node.getNodeData("navigationTitle").getString();
return StringUtils.defaultIfEmpty(StringUtils.defaultIfEmpty(navigationTitle, node.getTitle()), node.getName());
}



 Comments   
Comment by Graham Little [ 06/Nov/09 ]

This is a big issue for us (SCEE) - can Magnolia advise how quickly this might be fixed?

Comment by Philipp Bärfuss [ 06/Nov/09 ]

Hi Graham,

The best and safest way to escalate an issue is in case you are a customer to create a support ticket. I will try to fix it for STK 1.2, which will be released around 16th of November.

Comment by Philipp Bärfuss [ 06/Nov/09 ]

If you need it urgently for STK 1.1 you can apply the attached patch.

Philipp

Comment by Graham Little [ 06/Nov/09 ]

Many thanks for the speedy fix - we will apply the patch asap

Thanks

Comment by Philipp Bärfuss [ 08/Nov/09 ]

A nicer fix can be done in the abstract renderer itself. This will be shipped with Magnolia 4.2

Comment by Graham Little [ 09/Nov/09 ]

A problem we have is that Jan gave us some on the fly bugfixes which we dont have the source to, and need to combine with this fix. Is he available? Or do you know if he has checked these in separately?

Thanks,
Graham

Comment by Graham Little [ 09/Nov/09 ]

No matter - we found Jan -many thanks

Generated at Mon Feb 12 07:27:38 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.