[MGNLSTK-535] STK JDK 1.5 cleanups (for each loops, parameterized lists, removing unboxing) Created: 23/Nov/09 Updated: 19/Jan/11 Resolved: 17/Dec/10 |
|
| Status: | Closed |
| Project: | Magnolia Standard Templating Kit (closed) |
| Component/s: | base system |
| Affects Version/s: | 1.2 |
| Fix Version/s: | 1.4.2 |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Ryan Gardner | Assignee: | Magnolia International |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Template: |
|
| Patch included: |
Yes
|
| Acceptance criteria: |
Empty
|
| Testcase included: |
Yes
|
| Date of First Response: |
| Description |
|
I noticed a few methods in STK Util could benefit by using parameterized lists. Upon looking deeper, I noticed a number of places that for / while loops could be replaced with "for each loops" and make the code easier to read and simpler to maintain. In also removed instances of unnecessary unboxing. All three of these changes are implemented in separate patches, and I also have one that has all the changes combined into one patch (whichever you find easiest to work with) (tested this and all tests apply fine after these changes are applied) |
| Comments |
| Comment by Ryan Gardner [ 23/Nov/09 ] |
|
this is the patch with all the changes applied to it in one patch |
| Comment by Magnolia International [ 17/Dec/10 ] |
|
Hey Ryan, sorry we didn't pick this up earlier, just applied the patches, thanks ! |