[MGNLSTK-701] Dialog shouldn't be hard-coded in in stkRedirect template Created: 05/Nov/10  Updated: 20/Jan/11  Resolved: 20/Jan/11

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: templates
Affects Version/s: 1.3.5
Fix Version/s: 1.4.2

Type: Improvement Priority: Major
Reporter: Vivian Steller Assignee: Ondrej Chytil
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Patch included:
Yes
Acceptance criteria:
Empty
Date of First Response:

 Description   

stkRedirect.ftl:

change line 2 from:

[@cms.mainBar dialog="stkRedirect" /]

to

[@cms.mainBar dialog="${def.dialog!'stkRedirect'}" /]


 Comments   
Comment by Magnolia International [ 17/Dec/10 ]

Thanks, patch applied !

Just for nitpicking, creating patches from the root of the project with
svn diff > MGNLSTK-XYZ.patch
(or using whatever your IDE provides to do this) helps us apply them faster without having to search for the file and the lines to patch. Also helps you by not having to describe it manually

Comment by Vivian Steller [ 17/Dec/10 ]

thanks Grég! Your right, a patch would be much more convenient... when the time-punch machine ticked for the customer I was to much in a hurry to check out trunk and fix it there. Next time, I'll hopefully have a check out ready and do the change there, which I need for Java changes anyway, right

I'll give my best
Cheers!

Comment by Philipp Bärfuss [ 19/Jan/11 ]

The dialog should then be configured in the paragraph definition (like everywhere) and not explicitly noted in the script.

Comment by Federico Grilli [ 20/Jan/11 ]

There's no proper paragraph, this being a functional template with only a dialog associated with it. The dialog name is already specified in the template definition.

Generated at Mon Feb 12 07:29:35 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.