[MGNLSTK-721] DialogDAM: Should be extendable for usage within data module - getDamSupport() should be protected Created: 02/Dec/10  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: controls
Affects Version/s: 1.3.5, 1.4
Fix Version/s: 1.4.x

Type: Improvement Priority: Minor
Reporter: Christian Ringele Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File magnolia-module-standard-templating-kit.patch    
Issue Links:
relation
is related to MAGNOLIA-3429 DialogFile should be repository aware... Closed
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Date of First Response:

 Description   

For usage of the DAM Dialog/Control within the data module, the class DialogDAM.java should be expendable.
When using within the data module, the detection of a DAMSupport configuration out of a site definition can't work.
There for the method getDamSupport() should be protected, for providing a DAMSupport configuration from other places.
Second the access to the non existing DAMSupprt will result in a null violation within the constructor.
I have added comments to the code how I think it should be solved (always returning the default site definition at least).



 Comments   
Comment by Christian Ringele [ 02/Dec/10 ]

Both issues are found in the context of: Using DAM control in data module.

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 07:29:46 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.