[MGNLSTK-789] Create basic AbstractSTKRenderTestCase based on AbstractRenderTestCase Created: 18/Aug/11  Updated: 25/Aug/11  Resolved: 23/Aug/11

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: build
Affects Version/s: None
Fix Version/s: 1.4.5

Type: Improvement Priority: Neutral
Reporter: Christian Ringele Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MAGNOLIA-3806 MockHierarchyManager.isGranted() shou... Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Comments   
Comment by Christian Ringele [ 19/Aug/11 ]

This first implementation works fine with these first three render tests:
info.magnolia.module.templatingkit.paragraphs.FooterAboutParagraphTest
info.magnolia.module.templatingkit.templates.RedirectTemplateRenderTest
info.magnolia.module.templatingkit.paragraphs.PURLoginFormRenderTest

Comment by Jan Haderka [ 19/Aug/11 ]

SurefireModuleManager - either that message is invalid and should go away completely or it is potentially valid and then you should just change logging level to debug for example. Commented out code just clutters the class and makes it harder to read ... not to mention that it is redundant as old copy is still under version control.

Comment by Christian Ringele [ 19/Aug/11 ]

Switched to debug level, that's the best choice.
Didn't get that idea, thanks for the hint.

Comment by Philipp Bärfuss [ 23/Aug/11 ]
  • we should set the site on the aggregation state (many code in stk relays on that)
  • access manager should be set in the MockHierarchyManager (will create a separate ticket)
  • too many methods to set the renderers (who would ever use them?)
  • create explicit registerSTKXXXX methods to avoid confusion
Generated at Mon Feb 12 07:30:26 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.