[MGNLSTK-952] Cleanup existing unmaintainable STK tests Created: 29/Sep/11  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: None
Affects Version/s: 2.0
Fix Version/s: 2.0.x, 2.6.x

Type: Task Priority: Major
Reporter: Christian Ringele Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLSTK-1298 Create an integration/UI test for the... Closed
relation
is related to MAGNOLIA-4058 Re-activate all disabled (@Ignore) Un... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

After reviewing associated code changes I see following outstanding tasks:

  • STKUtilQueryTest - ignored test should be removed
  • FooterAboutParagraphRenderingTest => delete
  • RedirectTemplateRendererTest - rewrite as integration test if there are no any redirects in there already
  • AbstractSTKRenderTestCase - delete
  • PURLoginFormRenderTest - delete

In case the above is not clear:

  • footer, pur are already tested by integration test crawler
  • redirect should be tested same way either by having demo-content using redirect or having sample content or having integration test page using redirect template and using crawler to validate it on every build


 Comments   
Comment by Eric Hechinger [ 06/Jan/12 ]

Creation of a Pattern class that allows to test ftl : HtmlHeaderRenderingTest

Comment by Jan Haderka [ 14/Mar/12 ]

Has to be revived ASAP or we might as well delete the tests as they would be too much out of sync with the code.

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 07:31:58 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.