[MGNLSTK-972] ThemeInstallTask should not depend on an existing theme configuration Created: 18/Jun/12  Updated: 02/Aug/16  Resolved: 02/Aug/16

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: themepop
Affects Version/s: 1.4.7, 2.0, 2.0.1, 2.0.2, 2.0.3
Fix Version/s: 2.0.x

Type: Bug Priority: Major
Reporter: Christian Ringele Assignee: Unassigned
Resolution: Outdated Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLSTK-973 ThemeInstallTask will never update a ... Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

The ThemeInstallTask expects an existing Theme configuration within the module's bootstrap files.

 new BootstrapSingleResource("", "", "/mgnl-bootstrap/theme-" + themeName + "/config.modules.standard-templating-kit.config.themes." + themeName + ".xml", ImportUUIDBehavior.IMPORT_UUID_COLLISION_REPLACE_EXISTING).execute(ctx);

When creating a new theme, there can't exist a theme configuration yet.
This is one of the most often stumbles for people when creating a custom theme.

The ThemeInstallTask should use a custom task, which first checks if the resource exists within the jar/module.



 Comments   
Comment by Christian Ringele [ 18/Jun/12 ]

Not everybody uses the Maven archetype, which would creates such a configuration.

Comment by Jan Haderka [ 19/Jun/12 ]

When creating a new theme, there can't exist a theme configuration yet.

I fail to see why this is an issue. You add the install task to your version handler and it fails because the file it needs to work is missing. You read the message it gives you, add the file, rerun the installation and everything is correct and on top of that you are now aware that you need the theme exported in xml if you want to use the install task. Or you don't have the theme yet, so you remove the install task until you have it ready. Either way this is what you do when developing. What would you expect task to do instead of failing? Not executing at all? It would create much worse sort of problems - your theme would not get installed and you would not know why. Even if you had exported the theme, but put it in the wrong location, you would not know that it's in wrong location and why your theme is not being bootstrapped and you would loose much more time trying to figure that out then you loose when task dutifully notifies you that it can't be used because it can't do its job properly.

Comment by Michael Mühlebach [ 02/Aug/16 ]

Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
Given that the this issue has seen no attention for quite a while and belongs to an old version, we're not going to address this issue any more. Instead we will focus on issues with a higher impact and more votes.
Under the assumption this issue is no longer relevant, I'm going to close it to set expectations so the issue doesn't stay open for ages with no updates. If it is still relevant please feel free to open a new issue in the appropriate project.

Generated at Mon Feb 12 07:32:09 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.