[MGNLSTK-989] Bootstrap of theme files must be handled by theme-pop and not by STK Created: 10/Aug/12 Updated: 26/Nov/13 Resolved: 26/Nov/13 |
|
| Status: | Closed |
| Project: | Magnolia Standard Templating Kit (closed) |
| Component/s: | themepop, update |
| Affects Version/s: | 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4 |
| Fix Version/s: | 2.0.15, 2.6.2, 2.7 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Samuel Schmitt | Assignee: | Robert Šiška |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Date of First Response: | |
| Sprint: | 5.1.2 |
| Description |
|
Files config.modules.standard-templating-kit.config.themes.pop-mobile.xml and config.modules.standard-templating-kit.config.themes.pop.xml are present in STK and are bootstraped by the version handler of STK. |
| Comments |
| Comment by Cesar Desales [ 31/Aug/12 ] |
|
The current implementation of the ThemeInstallTask prevents the bootstrapping of Mobile Themes. The main problem is that the rule to bootstrap files is too specific, relying only on the theme name. public void execute(InstallContext ctx) throws TaskExecutionException { new BootstrapSingleResource("", "", "/mgnl-bootstrap/theme-" + themeName + "/config.modules.standard-templating-kit.config.themes." + themeName + ".xml", ImportUUIDBehavior.IMPORT_UUID_COLLISION_REPLACE_EXISTING).execute(ctx); Please change to allow all files under the directory to be boostrapped. |
| Comment by Cesar Desales [ 31/Aug/12 ] |
|
Class ThemeVersionHandler contains a magic number, you may want to consider removing it or changing for a constant. final List<Task> tasks = new ArrayList<Task>(3); |