[MGNLSTK-994] Request: New method for ThemeImpl Class: getExtraJsFiles Created: 16/Aug/12 Updated: 02/Jul/18 Resolved: 02/Jul/18 |
|
| Status: | Closed |
| Project: | Magnolia Standard Templating Kit (closed) |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | New Feature | Priority: | Neutral |
| Reporter: | Stef te Winkel | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 2 |
| Labels: | STK, jsFiles, theme | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Date of First Response: |
| Description |
|
In order to have the possibility to include JsFiles in the header as well as in the Body, 2 different methods getJsFiles and getExtraJsFiles (or something) would be great. In the Theme you could then also provide two sets of Js Files. At the moment its eather
Thanks! |
| Comments |
| Comment by Magnolia International [ 05/Dec/12 ] |
|
I would suggest naming this more explicitly, i.e. getBodyJsFiles. If not, another possibility would be to subclass Resource like it's been done for CssFile and add a position property to specify where the <script> tag belongs (head, startOfBody, endOfBody) Thoughts ? |
| Comment by Edgar Vonk [ 03/Jul/13 ] |
|
Hi Gregory, A related question: is it possible to use a custom theme implementation class for our theme in Magnolia? Is it possible to define a custom theme impl class (which extends from Magnolia's ThemeImpl) somewhere? Ideally in our theme module configuration. |
| Comment by Jan Haderka [ 02/Jul/18 ] |
|
STK have been deprecated in September 2017. As part of this project nearing end-of-life, we are not planning to fix any of the existing issues except for the critical security issues. For more details, please consult documentation. |