Make module compatible with Magnolia 5 (MGNLSYNC-22)

[MGNLSYNC-24] Create UI for synchronization Created: 10/Dec/13  Updated: 29/Mar/22  Resolved: 13/Dec/13

Status: Closed
Project: Magnolia Synchronization Module
Component/s: None
Affects Version/s: None
Fix Version/s: 1.5

Type: Sub-task Priority: Neutral
Reporter: Jaroslav Simak Assignee: Jaroslav Simak
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Date of First Response:
Team: Nucleus

 Comments   
Comment by Mikaël Geljić [ 11/Dec/13 ]
  • Styling the "required star" is theming (i.e. not a custom style for a single app) so it should be handled by the Vaadin theme styles (UI). I added it our form.scss and will push it shortly.
  • The problem with @Stylesheet annotation is that 1st it will download/append a new CSS file; then such generic CSS rules might apply as well to other unwanted places in the admincentral. For custom app styles we also have app theming (tentatively encourages to scope the styles with the app-[mytheme] parent selector) but it doesn't apply here.
  • Then get rid of the WorkspaceComboBox class, use a vanilla ComboBox instead, we're not augmenting the component with generic widget capabilities.
  • Finally you may also do it in tools modules O
Generated at Mon Feb 12 07:39:06 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.