[MGNLSYNC-44] Syncing nodes with missing versions Created: 28/May/20  Updated: 29/Mar/22  Resolved: 10/Jun/20

Status: Closed
Project: Magnolia Synchronization Module
Component/s: Core, REST
Affects Version/s: 1.8.2, 1.9
Fix Version/s: 1.8.3, 1.9

Type: Bug Priority: Neutral
Reporter: Richard Gange Assignee: Yen Lac Tue
Resolution: Fixed Votes: 0
Labels: maintenance
Remaining Estimate: 0d
Time Spent: 2h 23m
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLSYNC-42 Synchronization manager does not comp... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Sprint: Maintenance 10, Maintenance 11
Story Points: 3
Team: Nucleus

 Description   

The case can sometimes occur where a node has the hasVersion mixin but the versions do not exist.

'stories':
  'jcr:mixinTypes': ['mgnl:hasVersion']

Which can lead to:

2020-05-25 13:50:20,552 DEBUG ynchronization.commands.RestSynchronizationCommand: Synchronization execuded successfully for node /travel/tour.
2020-05-25 13:50:20,568 ERROR info.magnolia.module.scheduler.CommandJob         : Cannot execute command {0}-{1}.
java.lang.NullPointerException: null
	at info.magnolia.synchronization.commands.RestSynchronizationCommand.execute(RestSynchronizationCommand.java:87) ~[magnolia-synchronization-rest-1.9-beta2.jar:?]
	at info.magnolia.synchronization.commands.RestSynchronizationCommand.execute(RestSynchronizationCommand.java:124) ~[magnolia-synchronization-rest-1.9-beta2.jar:?]
	at info.magnolia.synchronization.commands.RestSynchronizationCommand.execute(RestSynchronizationCommand.java:69) ~[magnolia-synchronization-rest-1.9-beta2.jar:?]
	at info.magnolia.commands.MgnlCommand.executeSynchronized(MgnlCommand.java:80) ~[magnolia-core-6.2.jar:?]
	at info.magnolia.commands.MgnlCommand.execute(MgnlCommand.java:69) ~[magnolia-core-6.2.jar:?]
	at info.magnolia.module.scheduler.CommandJob.execute(CommandJob.java:110) [magnolia-module-scheduler-2.3.3.jar:?]
	at org.quartz.core.JobRunShell.run(JobRunShell.java:202) [quartz-2.3.2.jar:?]
	at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:573) [quartz-2.3.2.jar:?]

This needs to be fixed in both commands:

  • RestSynchronizationCommand
  • SynchronizationCommand

 

AC

  • Check whether if it happens only for stories


 Comments   
Comment by Richard Gange [ 28/May/20 ]
2020-05-28 14:59:00,382 INFO  fig.source.yaml.decoration.YamlDefinitionDecorator: Applied YAML file based decorator from [/dam-app/decorations/ui-framework/fieldTypes/richText.yaml] to definition provider [[fieldType] definition [richText] with reference id: [richText] from module [ui-framework] at [richText]]
2020-05-28 14:59:05,716 INFO  info.magnolia.module.scheduler.SchedulerModule    : Job synchronization-20200528-145905714 added [06 59 14 28 05 ? 2020]. Will fire first time at Thu May 28 14:59:06 CEST 2020
2020-05-28 14:59:06,016 INFO  info.magnolia.module.scheduler.CommandJob         : Starting job [synchronization-20200528-145905714]...
2020-05-28 14:59:10,606 ERROR ynchronization.commands.RestSynchronizationCommand: Broken version history. No versions found for node /travel/stories.
2020-05-28 14:59:11,555 ERROR ynchronization.commands.RestSynchronizationCommand: Broken version history. No versions found for node /travel/stories/story.
2020-05-28 14:59:18,239 INFO  info.magnolia.module.scheduler.CommandJob         : Job executed successfully [synchronization-20200528-145905714]
Generated at Mon Feb 12 07:39:19 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.