[MGNLSYNC-56] SynchronizationRequests can be created with non-unique ids Created: 24/Mar/21 Updated: 20/Jul/22 Resolved: 13/May/22 |
|
| Status: | Closed |
| Project: | Magnolia Synchronization Module |
| Component/s: | None |
| Affects Version/s: | 2.0 |
| Fix Version/s: | 2.0.1 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Brandon Murdoch | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | Not Specified | Time Spent: | Not Specified |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Sub-Tasks: |
|
||||||||||||||||||||||||||||||||||||||||
| Template: | |||||||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||||||
| Bug DoR: |
[X]*
Steps to reproduce, expected, and actual results filled
[X]*
Affected version filled
[ ]*
6.1.6
|
||||||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||||||
| Epic Link: | Nucleus Quality Maintenance | ||||||||||||||||||||||||||||||||||||||||
| Sprint: | Nucleus 10 | ||||||||||||||||||||||||||||||||||||||||
| Story Points: | 3 | ||||||||||||||||||||||||||||||||||||||||
| Team: |
| Description |
| Comments |
| Comment by Antonín Juran [ 03/May/22 ] |
Discovery completedUnique part of identifier of SynchronizationRequest are milliseconds of current date/time - created in its makeIdentifier() method (https://git.magnolia-cms.com/projects/ENTERPRISE/repos/synchronization/browse/magnolia-synchronization-core/src/main/java/info/magnolia/synchronization/manager/SynchronizationRequest.java#43). Multiple instances of SynchronizationRequest can have the same identifier if they're created too fast in a loop. In order to have each SynchronizationRequest instance unique UUID we could replace or append to formatted "current date" part an UUID created by java.util.UUID.randomUUID(). |
| Comment by Rabie Hayoun [ 06/May/22 ] |
|
| Comment by Jaromir Sarf [ 13/May/22 ] |
|
For RN: SynchronizationRequest class uses UUID.randomUUID() method to generate identifier instead of date based generating. |