[MGNLTAGS-38] Cannot open http://www.google.com or Google Analytics dashboard in dashboard subapp, though other URLs work Created: 09/Jun/14  Updated: 12/Jun/14  Resolved: 11/Jun/14

Status: Closed
Project: Marketing Tags Manager
Component/s: None
Affects Version/s: 1.0
Fix Version/s: 1.0

Type: Bug Priority: Critical
Reporter: Cheng Hu Assignee: Peili Liang
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Link button.png     PNG File OpenBaiduDashboard.png     PNG File OpenBaiduDashboard_LinkButton.png     PNG File OpenGoogleDashboard.png     PNG File OpenGoogleDashboard_LinkButton.png     PNG File OpenGoogleInBrowserTabFromDashboardLink.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   
  • Do not forget VPN, since Google is blocked from China at the moment.
  • Test whether it works if we do not have the spinner.


 Comments   
Comment by Peili Liang [ 10/Jun/14 ]

When I open the console of developer tools in chrome browser, I found an error info:
Refused to display 'https://www.google.ch/?gws_rd=cr,ssl&ei=mKyWU-K2NKm8ygPt3oCwAg' in a frame because it set 'X-Frame-Options' to 'SAMEORIGIN'.
I try to find the issue by google, finally I have no any ideas about it.
reference link:

Maybe we should open the dashboard in a new browser tab to prohibit the similar issue. but it need to investigate how to open the dashboard in a new browser by vaadin.

Comment by Cheng Hu [ 10/Jun/14 ]

From the experience of others on the web, it seems like there may be no way to embed the Google Analytics dashboard in a subapp iFrame, since it directly forbids it in the header.

From work on a previous issue, there is also no straightforward way to open a new browser window/tab with the URL without it being considered a pop-up, because the Action buttons in the Action bar are automatically generated on the client side where there is no straightforward way to assign JavaScript click listeners to them.

So the only option may be not to have the dashboard concept at all.

Comment by Andreas Weder [ 11/Jun/14 ]

Nice suggestion. Or rather: nice addition, actually, since this also adds value for cases where a dashboard properly displays inside an iframe.

I have three requests still:

  • I wouldn't expose the URL, but only show an element we call a "link button" (see attached screenshot). A link button is essentially a link, but it remains blue even if already visited, and it's characters are all uppercase.
  • I suggest we change the text on that button so that it offers help: „[CLICK HERE TO OPEN DASHBOARD] in a new browser tab“. Only the first part is a link button
  • please properly vertically center the link button within the gray bar.
Comment by Christoph Meier [ 11/Jun/14 ]

review:
in DashboardViewImpl: Makes sure that generated HTML surrounds attribute-values with quotes.
Usage of quotes or double-quotes may be optional depending on the value, anyway it is recommended.
(See W3C-spcecs http://goo.gl/Oth4Ge)

instead of
new Label("<a href=" + url + ">lala</a>") ... do something like
new Label("<a href='" + url + "'>lala</a>") ... or
new Label("<a href=\"" + url + "\">lala</a>")

Generated at Mon Feb 12 10:13:54 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.