[MGNLTAGS-42] Make module EE Created: 12/Jun/14  Updated: 17/Jun/14  Resolved: 13/Jun/14

Status: Closed
Project: Marketing Tags Manager
Component/s: None
Affects Version/s: 1.0
Fix Version/s: 1.0

Type: Task Priority: Major
Reporter: Federico Grilli Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLTAGS-33 Migrate new areas and its model to STK Closed
is related to MAGNOLIA-5809 Move marketing-tags away from ce-bund... Closed
is related to MGNLSTK-1388 Add areas to default prototype to ins... Closed
is related to MULTISITE-20 Add areas to default prototype to ins... Closed
is related to MGNLTAGS-41 Duplicate i18n keys Closed
is related to MGNLSTK-1395 Remove references to marketing-tags Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

Marketing-tags will be an EE module.

Things to do:

  • Move away the module from ce-bundle together with its integration tests to ee-bundle
  • Some code now in STK needs to be moved to this module but the new body areas which have been created will remain there as a placeholder for whoever may need them
    • New STK areas, as they are in the bootstrap files, have DefaultScriptAreaModel (a placeholder basically) model. This is replaced by ScriptAreaModel from marketing-tags
    • Model class for new areas moved from STK to the tags module
    • Version handler for tags module need to change to install the model in the three areas
    • JUnit test for model class moved from STK to the tags module
    • STK pom change so it no longer depends on tags for JUnit test
    • New STK areas should have placeholder FTL rather than the existing, which no longer have a model to use
    • FTL for areas should move back to the tags module
    • Version handler for tags module need to change to install the FTL in the three areas
    • STK module descriptor need to remove dependency on tags module
    • Tags module descriptor need to add dependency on STK
    • Tags module version handler needs to install same FTL and model in multisite prototype
      • NOTE: Multisite probably doesn't need to change
    • Tags module descriptor needs to depend on multisite (actually I made it depend on STK and it looks fine)
    • Remove tags module from unit tests in STK where they had to be added (DemoProjectVersionHandlerTest.java)
  • Copyright comments in tags module code need to change to EE

See also related issues linked to this one



 Comments   
Comment by Federico Grilli [ 13/Jun/14 ]

commits hashes are

3ad34e20308749a80f2bfa3d596b3a5a3e5249d6 (this one under wrong jira issue MAGNOLIA-5809, will be fixed when squashing/merging into master)
8886cd5313caffaef2e75994f76525d657bef4fb (this one under wrong jira issue MGNLSTK-1395, will be fixed when squashing/merging into master)
aefc55bb2b4f92e4a253bff6cd593d1453613d21

Comment by Cheng Hu [ 16/Jun/14 ]

Currently both marketing-tags and multisite depend on STK. marketing-tags' version handler modifies STK's prototype, which is then copied by multisite's version handler into multisite's prototype. This is why the prototype in EE ends up being correct. However, this requires that marketing-tags must be loaded before multisite and currently this order is not enforced in the module descriptor dependencies. If multisite is loaded before marketing-tags, the EE prototype will not have marketing-tags' modifications.

If we do not want multisite to depend on marketing-tags, maybe the only option is to have marketing-tags depend on multisite, and to modify marketing-tags' version handler to also modify the prototype created by multisite?

Comment by Cheng Hu [ 16/Jun/14 ]

Does the comment in magnolia-tags-nodetypes.xml need to be changed if it is no longer CE?

Comment by Federico Grilli [ 16/Jun/14 ]

If we do not want multisite to depend on marketing-tags, maybe the only option is to have marketing-tags depend on multisite, and to modify marketing-tags' version handler to also modify the prototype created by multisite?

Yes, I'd go for the second option, i.e. marketing-tags depending on multisite and not the other way round

Does the comment in magnolia-tags-nodetypes.xml need to be changed if it is no longer CE?

Don't think so. It's JR Apache License, we don't want to change that.

Generated at Mon Feb 12 10:13:56 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.