[MGNLTAGS-42] Make module EE Created: 12/Jun/14 Updated: 17/Jun/14 Resolved: 13/Jun/14 |
|
| Status: | Closed |
| Project: | Marketing Tags Manager |
| Component/s: | None |
| Affects Version/s: | 1.0 |
| Fix Version/s: | 1.0 |
| Type: | Task | Priority: | Major |
| Reporter: | Federico Grilli | Assignee: | Federico Grilli |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||
| Task DoR: |
Empty
|
||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||
| Description |
|
Marketing-tags will be an EE module. Things to do:
See also related issues linked to this one |
| Comments |
| Comment by Federico Grilli [ 13/Jun/14 ] |
|
commits hashes are 3ad34e20308749a80f2bfa3d596b3a5a3e5249d6 (this one under wrong jira issue |
| Comment by Cheng Hu [ 16/Jun/14 ] |
|
Currently both marketing-tags and multisite depend on STK. marketing-tags' version handler modifies STK's prototype, which is then copied by multisite's version handler into multisite's prototype. This is why the prototype in EE ends up being correct. However, this requires that marketing-tags must be loaded before multisite and currently this order is not enforced in the module descriptor dependencies. If multisite is loaded before marketing-tags, the EE prototype will not have marketing-tags' modifications. If we do not want multisite to depend on marketing-tags, maybe the only option is to have marketing-tags depend on multisite, and to modify marketing-tags' version handler to also modify the prototype created by multisite? |
| Comment by Cheng Hu [ 16/Jun/14 ] |
|
Does the comment in magnolia-tags-nodetypes.xml need to be changed if it is no longer CE? |
| Comment by Federico Grilli [ 16/Jun/14 ] |
Yes, I'd go for the second option, i.e. marketing-tags depending on multisite and not the other way round
Don't think so. It's JR Apache License, we don't want to change that. |