[MGNLTAGS-49] Enable FM processing of tag code Created: 17/Oct/14  Updated: 27/Mar/15  Resolved: 01/Dec/14

Status: Closed
Project: Marketing Tags Manager
Component/s: None
Affects Version/s: None
Fix Version/s: 1.1

Type: Improvement Priority: Neutral
Reporter: Jan Haderka Assignee: Jan Haderka
Resolution: Fixed Votes: 0
Labels: maintenance, next
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Some of the tags are more dynamic and can accept extra information about operations then just tracking code. This is specially case for conversion tags, etc where submitted information should contain type of conversion or products one is interested in, etc.
Enabling FM processing on the tag snippet allows dynamic insertion of the information that is available in the context of the page.



 Comments   
Comment by Jan Haderka [ 17/Oct/14 ]

Code for processing is committed on the branch for further discussion of the approach.

Comment by Cheng Hu [ 19/Nov/14 ]

@Jan

We went through a review. Do you think this modification requires a unit test?

Comment by Jan Haderka [ 01/Dec/14 ]

IMO, there is no need to cover query itself as this is normal JCR query. Refactoring itself is already covered by plenty of other tests ... And if I ran them earlier, I would have seen that they were broken. Sorry about that. Fixed now.
If you require test for specific part of the code, please indicate what you want to have covered by the test.

Comment by Roman Kovařík [ 17/Dec/14 ]
[ERROR] Total coverage of 42.1% did not meet target of 43%

// TODO: is there a way to call FreemarkerRenderer instead of setting up all manually?
I believe that you can get it via info.magnolia.rendering.renderer.registry.RendererRegistry#getRenderer

Comment by Jan Haderka [ 19/Dec/14 ]

Thx. W/ both MGNLTAGS-48 and MGNLTAGS-49 coverage is actually fine:

        Total: 45.1%                                                                                                            
Complexity:-
   Avg Method: 2.154
      Density: 0.343
        Total: 84

Generated at Mon Feb 12 10:14:00 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.