[MGNLTEST-102] Refactor MagnoliaRestClient making it aware of public / author instances Created: 29/Sep/20  Updated: 21/Oct/20  Resolved: 16/Oct/20

Status: Closed
Project: Magnolia Test Framework
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0.2

Type: Improvement Priority: Neutral
Reporter: Michael Duerig Assignee: Michael Duerig
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Epic Link: core-TF-features-bugs-improvements
Sprint: TE 13
Story Points: 3

 Description   

MagnoliaTestClient currently uses various - partially conflicting - ways to refer to a Magnolia instance:

  • MagnoliaRestClient#httpHost refers to testSettings.magnoliaHostUrl()
  • Various methods refer to directly to either Instance.DIRECT_AUTHOR or Instance.DIRECT_PUBLIC
  • Various methods take a String instanceContext argument.

Optimally a MagnoliaRestCient should be bound to an Instance when instantiating instead.

 

Additionally we should revisit the exception semantics of the methods of the rest clients. Many methods don't throw the declared exceptions at all. Some throw it when they'd rather should return a `false` instead.


Generated at Mon Feb 12 07:45:35 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.