[MGNLTEST-114] Enrich definition rest api with decorator metadata Created: 11/Nov/20 Updated: 09/Nov/23 |
|
| Status: | Selected |
| Project: | Magnolia Test Framework |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Mikaël Geljić | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Epic Link: | core-TF-features-bugs-improvements | ||||||||||||||||
| Team: | |||||||||||||||||
| Work Started: | |||||||||||||||||
| Description |
|
—so that test-framework fixtures or tests can verify (and wait until) certain decorators are applied. Note: definitions-rest-api was introduced in https://git.magnolia-cms.com/projects/MODULES/repos/definitions-rest-api/browse
|
| Comments |
| Comment by Maxime Michel [ 20/Sep/21 ] |
|
mgeljic which tests or general scenarios would benefit from this? |
| Comment by Mikaël Geljić [ 23/Sep/21 ] |
|
This was about verifying that a decorator is applied when bootstrapping @LightModule fixtures. For example a light-module might bring an app and decorate appLauncherLayout to register it. Right now we try to encapsulate this waiting time in the TF (see LightModulesSupport#loadLightModules:141), but maybe a better way would be to facilitate those eventual awaits from actual tests. What matters is less that the decorator is applied, than what it does takes effect, and how to retry until then (rest-client eval, page refresh). |