[MGNLTEST-125] APPLICATION_JSON shouldn't be needed to pass when using MagnoliaRestClient in tests Created: 01/Dec/20  Updated: 23/Aug/21  Resolved: 23/Aug/21

Status: Closed
Project: Magnolia Test Framework
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Adam Siska Assignee: Adam Siska
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: core-TF-features-bugs-improvements

 Description   

We have

private static final String APPLICATION_JSON = "application/json";

constants in UI test that using MagnoliaRestClients.. Looks like impl. detail which is not needed to be aware of on the test level.



 Comments   
Comment by Christoph Meier [ 23/Aug/21 ]

asiska - the MagnoliaRestClient has been refactored.
Methods asking for the "acceptedResponseType" are all deprecated now. 
New methods have been added, where  MediaType.APPLICATION_JSON is used as default accepted response type. (iirc this was done in the context of MGNLTEST-143)

Can we close this ticket?

Or was the reason of this ticket to refactor tests which are using the now deprecated methods of the MagnoliaRestClient?

Comment by Adam Siska [ 23/Aug/21 ]

Not sure if we need to systematically remove deprecated usages of this (in CE/DX fun. tests), if any. So we can close or reformulate to remove these.. I would be for closing.

Comment by Christoph Meier [ 23/Aug/21 ]

Ok. Thanks asiska, I'm closing this now.

I see that people replace usage of deprecated MagnoliaRestClient methods in when on classes where it can be found. I think that's enough.

Comment by Christoph Meier [ 23/Aug/21 ]

MagnoliaRestClient has been refactored - methods asking for the response-type have been deprecated.  Closing this now after an exchange with the reporter of the ticket.

Generated at Mon Feb 12 07:45:48 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.