[MGNLTEST-14] ContentApp#selectRowByPath method name and signature may be misleading Created: 10/Jan/20  Updated: 09/Nov/21  Resolved: 09/Nov/21

Status: Closed
Project: Magnolia Test Framework
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Federico Grilli Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: QA&Testing, ease-of-usage, ui-test-fwk
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLTEST-84 Add shorthand to select row directly Closed
relation
is related to MGNLTEST-120 Grid#selectRowByPath might select wro... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: core-TF-features-bugs-improvements
Story Points: 1

 Description   

ContentApp#selectRowByPath(String absolutePath) may trick some devs into thinking that absolutePath is a JCR path whereas this is not necessarily the case. Path here actually represents labels next to Grid expander elements that need to be expanded in order to get to the element to select.
The method is effectively the same as the old framework's AbstractMagnoliaUITest#expandTreeAndSelectAnElement(java.lang.String).
Perhaps renaming the new method along those lines and a better javadoc is all we need.



 Comments   
Comment by Christoph Meier [ 13/Jan/20 ]

The currently misleading javadoc will already be improved in the context of MGNLCE-170.
(It will be added as QA commit after the merge of the PR for MGNLCE-170).

Comment by Maxime Michel [ 04/Oct/21 ]

Reopening after we unearthed an occurence (see linked ticket) where this is actually an issue.

Comment by Christoph Meier [ 09/Nov/21 ]

This one has been tackled. Rico added a now very precise javadoc explaining what the method really does.
Implementation was not changed as decided long time ago.

Closing it now.

Generated at Mon Feb 12 07:44:43 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.