[MGNLTEST-150] dx-core INT tests fail with test-fwk:1.1.0 / likely a docker issue Created: 01/Apr/21  Updated: 05/Apr/21  Resolved: 05/Apr/21

Status: Closed
Project: Magnolia Test Framework
Component/s: None
Affects Version/s: 1.1.0
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Christoph Meier Assignee: Christoph Meier
Resolution: Fixed Votes: 0
Labels: VN-Testing
Remaining Estimate: Not Specified
Time Spent: 3h
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLTEST-151 raise org.testcontainers:testcontaine... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[X]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Epic Link: core-TF-features-bugs-improvements

 Description   

We did raised test-fwk to 1.1.0 on both dx-core and ce.
While it works fine on ce, dx-core constantly failed. For an example of a failed build on jenkins see https://jenkins.magnolia-cms.com/job/platform/job/dx-core/job/master/296/.

It also fails on local envs. Stacktrace from local failure: https://gist.github.com/Watcher24/0a851157d06e36a9c72eaa1e45d47028

Seems to be a docker issue.

java.lang.NoClassDefFoundError: Could not initialize class info.magnolia.test.setup.DockerHelper

I reverted the 2 latest commits, now dx-core INT tests run again ... at least they have no docker issues. (Some tests arbitrary fail now and then ... but for other reason.)

Here’s probably a hint why it fails: https://github.com/testcontainers/testcontainers-java/issues/2860


slack discussion of the issue: https://magnolia-cms.slack.com/archives/CG69M3JGG/p1617080918009700


Identified problem and proposed solution(s) (by Sasha)

Problem:

testcontainers dependency is old! (we now use the 1.15.1 vs 1.8.3 there).
This comes from ce/magnolia-integration-tests/magnolia-integration-tests-framework/pom.xml 
lines 169ff

Possible solutions:

  • let the test-fw to bring it in transitively (not great)
  • bump the version explicitly
  • synch the dependency version over boms 

For the time being, we bump the version in magnolia-integration-tests-framework/pom.xml.

 

 


Generated at Mon Feb 12 07:46:03 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.