[MGNLTEST-161] NPE ImageResponse.dimension() when target image not exist Created: 22/Apr/21 Updated: 01/Jun/21 Resolved: 06/May/21 |
|
| Status: | Closed |
| Project: | Magnolia Test Framework |
| Component/s: | None |
| Affects Version/s: | 1.1.0 |
| Fix Version/s: | 1.2.0 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Evzen Fochr | Assignee: | Christoph Meier |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 3h | ||
| Original Estimate: | Not Specified | ||
| Template: | |
| Acceptance criteria: |
Empty
|
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[X]*
Steps to reproduce, expected, and actual results filled
[X]*
Affected version filled
|
| Date of First Response: |
| Description |
Steps to reproduce
.. Logs, screenshots, gifs... Expected resultsget null .. Justify non-trivial expectations with a link to a doc or a relevant discussion. Actual resultsNPE is thrown WorkaroundDevelopment notes |
| Comments |
| Comment by Christoph Meier [ 06/May/21 ] |
|
I cannot reproduce the NPE on my local setup. The line where Evzen encountered the NPE was this:
String responseType = response.body().contentType().type();
But even when using HTTP HEAD response.body() is never null. Anyhow I have improved to make it NPE safe. So the PR will contain an improvement making the code more NPE safe, plus some more tests. |