[MGNLTEST-186] Remove copy-pasted code from testcontainers Created: 02/Nov/21 Updated: 15/Dec/21 Resolved: 01/Dec/21 |
|
| Status: | Closed |
| Project: | Magnolia Test Framework |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.2.4 |
| Type: | Task | Priority: | Neutral |
| Reporter: | Maxime Michel | Assignee: | Rishab Dhar |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 1.5h | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoR: |
Empty
|
||||||||||||||||
| Sprint: | Global Maintenance 1, Global Maintenance 2 | ||||||||||||||||
| Story Points: | 5 | ||||||||||||||||
| Description |
|
The TF has a ton of legacy code to deal with VNC recordings, i.e. SeleniumNodeVncSidekickContainer is mostly a copy-paste of a testcontainers class. This is a problem to maintain the project, for instance upgrade testcontainers to 1.5.3 which provides OOTB options to record to MP4. Rishab says he has an effort to address this that he would only need to wrap up. The solution is to extract the spinning up of containers from jvm to a separate docker container spun up from docker-compose. |