[MGNLTEST-188] Consolidate support for external instances Created: 13/Nov/21  Updated: 01/Feb/24  Resolved: 08/Nov/23

Status: Closed
Project: Magnolia Test Framework
Component/s: None
Affects Version/s: 2.0-cloud
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Mikaël Geljić Assignee: Unassigned
Resolution: Outdated Votes: 0
Labels: artt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
supersession
supersedes MGNLTEST-163 Make configurable list of test instances Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: SaaS ITs
Team: Foundation
Work Started:

 Description   

MGNLTEST-163 has been merged to the cloud-feature branch for some time; few weeks back, I had proceeded with further review, for what I deem necessary to address to merge it back to the main branch as 2.0:

  • We don't have good conventions yet for naming MP Config keys, but would suggest magnolia.test as prefix
  • DirectInstances terminology sounds legacy or too technical to be used for defaults, pbly sth like DefaultInstances?
  • Backwards compatibility: we accept that @Fixture@Cleanup annotations' instances parameter type is moving from enum to plain Strings. We also wanted to deprecate the constants or enum members prefixed with 'DIRECT_' anyway, so tests will need an update, worth doing it in one go.
  • Can @WithName smallrye annotations be replaced with MP config annotations?
  • InstancesManager may be an injectable component w/ MP config mappings, so we resolve config only upon init; might also expose the instance stream or collection to facilitate functional operations.


 Comments   
Comment by Christoph Meier [ 07/Nov/23 ]

mgeljic - I recently have created a BOARD for TAE ... Foundation board was a bit overloaded.
And while doing this - I clean up things.

I think this ticket can be closed - would you agree?

Comment by Christoph Meier [ 08/Nov/23 ]

Closing it ... really old stuff.
The info won't get lost ...

Comment by Mikaël Geljić [ 10/Nov/23 ]

that was before the spring-based config too

Generated at Mon Feb 12 07:46:26 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.