[MGNLTEST-202] Consider removing some VaadinWebElementWrapper#vaadinIsDone calls - or refine Created: 24/Mar/22  Updated: 19/Apr/22  Resolved: 13/Apr/22

Status: Closed
Project: Magnolia Test Framework
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Christoph Meier Assignee: Christoph Meier
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: 0.75d
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)

 Description   

Consider removing some VaadinWebElementWrapper#vaadinIsDone calls - or refine

We wrap some of our WebElements in Page Objects with the VaadinWebElementWrapper and then have calls #vaadinIsDone.
The idea is to let wait selenium until am async Vaadin call is done.
For an example see info.magnolia.test.selenium.pageobjects.Badge#open

The problem is - that we sometimes run into situations where "vaadin maybe is never done" - at least we run into timeouts.
(See error-log cioy/paste on gist )

The above described issue - "vaadin maybe is never done" - seems to be the underlying issue of MGNLTEST-198.

It also seems to be the reason when

expect.tasksBadge().open();

fails that often e.g. in PublicationWorkflowFunctionalTests (see MGNLEE-687).

My impression is that we use #vaadinIsDone too often.
We may want to consider removing some of the #vaadinIsDone calls - or we should rewrite it / refine it. At some point we should stop the checks and just try to proceed (returning true in #vaadinIsDone)

Or maybe can refine it.



 Comments   
Comment by Christoph Meier [ 13/Apr/22 ]

This is now replaced by MGNLTEST-208 and sub-tasks

Generated at Mon Feb 12 07:46:34 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.