[MGNLTEST-219] Improve & fix ContentApp filter-API Created: 13/Apr/22  Updated: 18/May/22  Resolved: 21/Apr/22

Status: Closed
Project: Magnolia Test Framework
Component/s: None
Affects Version/s: None
Fix Version/s: 1.3.1

Type: Bug Priority: Neutral
Reporter: Christoph Meier Assignee: Christoph Meier
Resolution: Fixed Votes: 0
Labels: VN-Testing
Remaining Estimate: Not Specified
Time Spent: 2d 0.5h
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLEE-671 Implements tests for refined tasks & ... Open
Template:
Acceptance criteria:
[X]* pages app filter by combobox
[X]* pages app filter by textfield
[X]* resources app filter by textfield
[X]* resources app filter by combobox
[X]* resources app filter by checkbox
[X]* tasks-app filter by combobox
[X]* notifications-app Filter by combobox on
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[X]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

 

ContentApp#filter(String columnLabel, String filterValue) works for some cases, but fails in other cases.

In the implementation - a TextField is instantiated - though in some cases it actually should rather be a combobox.

The method works on the resources-app to filter the origin, where the UI has a combobox.

It fails in notifications-app and tasks-app.

Add more self-tests to ensure scenarios work -> see Acceptance criteria



 Comments   
Comment by Christoph Meier [ 20/Apr/22 ]
  • New API:
    • #filterByText(String, String)
    • #filterByCombobox(String, String)
    • #filterByCheckbox(String, boolean)
  • Removed methods: filter(String, String); filter(String, boolean)
Comment by Christoph Meier [ 21/Apr/22 ]

Reviewed (by Sang) and integrated

Generated at Mon Feb 12 07:46:44 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.