[MGNLTEST-235] Cleanup fails to delete nodes with UTF8-chars in node-/file-name - failing silently! Created: 20/May/22 Updated: 16/Jun/22 Resolved: 10/Jun/22 |
|
| Status: | Closed |
| Project: | Magnolia Test Framework |
| Component/s: | None |
| Affects Version/s: | 1.3.1 |
| Fix Version/s: | 1.3.2 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Christoph Meier | Assignee: | Michael Duerig |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | foundation_team | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 2.5h | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Bug DoR: |
[X]*
Steps to reproduce, expected, and actual results filled
[X]*
Affected version filled
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Team: | |||||||||||||||||
| Description |
|
This example from PagesCoreFunctionalTests#pageNodeWithUtf8Chars fails since 6.3-hackathon/site-removal.
@Cleanup("website:/äëïöü")
(a) But Cleanup fails always - if the node name contains UTF8 characters. (b) And additional problem is that Cleanup fails silently. Related to (b)
See info.magnolia.test.fixture.JcrFixture.
|
| Comments |
| Comment by Michael Duerig [ 24/May/22 ] |
|
cmeier re. a) b) clean up actually does throw an exception when it fails. With the issue from c) not sure whether this is a good idea (at least at this point in time). I have some reminiscence of this being done on purpose. Maybe rdhar or mgeljic remember why we run fixture cleanup also before executing the test method. In any case, I would postpone this to a separate ticket and tackle it once we are done with our effort on fixing the tests that broke after the M6.3 merger. |
| Comment by Christoph Meier [ 25/May/22 ] |
|
(b) (c)
|
| Comment by Michael Duerig [ 25/May/22 ] |
|
Re-enabled pageNodeWithUtf8Chars, which was failing because of The test passes now for me locally. I keep an eye on Jenkins once the test passes there I resolve this ticket as fixed. |
| Comment by Christoph Meier [ 06/Jun/22 ] |
|
For the records: The issue has been fixed via Cleanup is still called twice. When called during @beforeEach - and if there is nothing to clean - it remains silent, which is good. If Cleanup finds the resource but fails to clean it up - it throws an exception. That's fine. Closing this one now |
| Comment by Christoph Meier [ 07/Jun/22 ] |
|
Adding same comment to both The issues still exist. on release/6.2-branch File website.ääööüü.yaml can be loaded. assertTrue(magnoliaRestClient.nodeExists("website", "/ääööüü")); fails. AND on master: |