[MGNLTEST-425] VncRecordingHelper evaluates wrong host (most of the times) on saas Created: 18/Jul/23 Updated: 06/Sep/23 Resolved: 06/Sep/23 |
|
| Status: | Closed |
| Project: | Magnolia Test Framework |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Christoph Meier | Assignee: | Christoph Meier |
| Resolution: | Resolved | Votes: | 0 |
| Labels: | VN-Testing, vncRecorder-issue | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 2d 6.5h | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Template: |
|
||||
| Acceptance criteria: |
Empty
|
||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[X] 
Architecture Decision Record (ADR)
|
||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||
| Epic Link: | reporting-and-coverage-improvments-and-fixes | ||||
| Work Started: | |||||
| Description |
|
private void resolveTestExecutorNodeHostName(){}
Update 2023-07-19We found two issues: Issue 1: Incorrect Selenium mode detectionProblemThe way VNC recorder detects if Selenium running in Standalone mode or Hub mode is checking container name "selenium-hub" is alive in Docker runtime environment or not.
this.isSeleniumHubOnDocker = DockerHelper.isContainerAlive(testSettings.seleniumHubContainerName());
This works as expected in local Docker, however, not ideal on Jenkins where we have a single Docker environment in a Jenkins node that run multiple testing jobs. In case one test job is running Selenium Hub mode while another test job is running Selenium standalone mode, we have incorrect detection. SolutionWe need to explicitly define and check Selenium mode for each testing job by using the supported variable "selenium.standalone". By default, SELENIUM_STANDALONE is true, so we don't need to adapt for standalone setup. Issue 2: In cloud-e2e, vncrecorder is using default port to access Selenium service.ProblemThe Selenium is exposing a random port for VNC access to a record: https://git.magnolia-cms.com/projects/CLOUD/repos/cloud-e2e/browse/docker-compose.yml#19 SolutionKeep the port align between Selenium service and vncrecorder service, like this example: https://git.magnolia-cms.com/projects/CLOUD/repos/hello-saas-e2e/browse/docker-compose.yml#36-38 |
| Comments |
| Comment by Christoph Meier [ 02/Aug/23 ] |
|
Changes on this project merged -> PR Now integrating changes on core-TF consumer-modules which are using selenium-hub |
| Comment by Christoph Meier [ 02/Aug/23 ] |
|
ce/master -> integrated -> PR |
| Comment by Christoph Meier [ 02/Aug/23 ] |
|
dx-core/master integrated -> PR |
| Comment by Christoph Meier [ 03/Aug/23 ] |
|
magnolia-sso integrated ->PR |
| Comment by Christoph Meier [ 10/Aug/23 ] |
|
ce-release/6.2 integrated -> PR |
| Comment by Christoph Meier [ 10/Aug/23 ] |
|
dx-core-master integrated ->commit |
| Comment by Christoph Meier [ 10/Aug/23 ] |
|
dx-core release/62 integrated -> commit |
| Comment by Christoph Meier [ 10/Aug/23 ] |
|
dx-core-ee9 integrated ->commit |
| Comment by Christoph Meier [ 10/Aug/23 ] |
|
ce-ee9 integrated ->commit |
| Comment by Christoph Meier [ 06/Sep/23 ] |
|
Also. integrated in addons-tests |