[MGNLTEST-75] Some integration test setting names aren't clear enough and/or don't reflect the actual state things Created: 05/Aug/20  Updated: 01/Sep/20  Resolved: 01/Sep/20

Status: Closed
Project: Magnolia Test Framework
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0.1

Type: Improvement Priority: Neutral
Reporter: Aleksandr Pchelintcev Assignee: Aleksandr Pchelintcev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: core-TF-features-bugs-improvements
Sprint: TE 8

 Description   
  • private/public ports can now be configured as a single host port: since we're moving to the Docker-compose based setup, we can alway communicate with the instance over the same port.
  • references to container, like e.g. directContainerRootURL are confusing: introduced before we introduced Docker there, 'container' implied the servlet container.
  • clarify the host name strategy as much as possible:
    • we have a "REST client case", i.e. when an external http client outside of Docker needs to access the running instance. We simply name such host name as hostName since it is the one visible to the whole world. By default such host name is localhost.
    • we also have the "selenium worker case" - typically from within Docker container running the workers. In this case localhost wouldn't obviously work, and we access magnolia instances via special Docker container-to-host IP/Hostname (172.17.0.1/host.docker.internal for macs).
  • Instance#getDomain -> Instance#getContextRoot: domain is a bit misleading here. The #getContextPath can be renamed also to hopefully clearer {{getWebappPath.

Generated at Mon Feb 12 07:45:19 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.