[MGNLTOOLS-90] Show the end of purge versions command execution Created: 18/Sep/19 Updated: 19/May/22 |
|
| Status: | Open |
| Project: | Repository Tools |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Jonathan Ayala | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Template: |
|
||||
| Acceptance criteria: |
Empty
|
||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||
| Team: | |||||
| Description |
|
When running purge versions command you never know when it reaches the end of the execution. It would be very useful to show any kind of progression so that users can be sure it is executed or not. There are some debug traces that show progression in methods info.magnolia.tools.commands.VersionStorePurgeCommand.execute(Context) and info.magnolia.tools.commands.VersionStorePurgeCommand.purge(Node). A possible solution would be adding a final log trace informing about the end of the execution right before returning true in line 117. info.magnolia.tools.commands.VersionStorePurgeCommand.execute(Context)
long count = 0;
while (versionIt.hasNext()) {
final Node versionNode = versionIt.next();
count++;
if (count % 100 == 0) {
log.debug("processed {} nodes.", count);
}
purge(versionNode);
}
<<<<<<<<<<<<<<<<<<<< HERE
return true;
}
|