[MGNLTPLSMPL-22] samplesFieldShowRoom dialog has i18nBasename set, but not labels for all fields Created: 19/Feb/16  Updated: 19/May/22  Resolved: 19/May/22

Status: Closed
Project: Freemarker Templating Samples
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Roman Kovařík Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLUI-3773 SelectFieldFactory should not transla... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty

 Description   

The old i18n requires the base name and keys to by explicitly set.
This is not the case for e.g. /modules/samples/dialogs/samplesFieldShowRoom/form/tabs/tabSwitch/fields/switchComposite/options/.
New i18n generates set of keys but if i18nBasename is set, then it takes the first key from the set and tries to translate with old i18n. This can break especially after fixing MGNLUI-3773 if the first i18n key in the set will be on another position (more supported keys would be added).

The easiest solution is to set labels for these options. Proper fix would be to remove i18nBaseNames and hardcoded labels so we can test new i18n in the integration test where is this dialog used.



 Comments   
Comment by Roman Kovařík [ 19/May/22 ]

Hello,

This ticket is now marked as closed due to one of the following reasons:

  • A long period of inactivity
  • Uses an old or Beta version of an application, module, or framework that we no longer support
  • The issue is no longer reproducible or has been fixed in later versions

If you are still facing a problem or consider this issue still relevant, please feel free to re-open the ticket and we will reach out to you.

Thank you,
The Magnolia Team

Generated at Mon Feb 12 02:03:03 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.