[MGNLUI-1016] ContentViews should have dedicated presenters Created: 28/Mar/13  Updated: 30/May/13  Resolved: 13/May/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 5.0

Type: Task Priority: Major
Reporter: Tobias Mattsson Assignee: Mikaël Geljić
Resolution: Fixed Votes: 0
Labels: apiteam, workbench
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
duplicate
is duplicated by MGNLUI-312 Workbench views should synchronize se... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Sprint: Beta 2

 Description   

For each of tree, list, thumbnail, search.



 Comments   
Comment by Mikaël Geljić [ 13/May/13 ]

Successfully introduced dedicated content presenters per content view type.

  • Resigned from getting rid of ViewType enum, can be done as an isolated step now
  • Choose dialogs work the same as on master, i.e. they regressed beforehand (LinkFieldSelection field is unused currently, column's displayInDialog is ignored, and current selection is not restored when opening the dialog)
  • Minor adaptations on dam and contacts were committed with this issue number.
  • Also there is now a good opportunity to simplify asset browser quite dramatically and reimplement it as a content presenter/view couple.
  • Please note two git commits accidentally landed on MGNLUI-1018.

Everything should work as expected and code-review may start. Meanwhile I will check for proper test results and coverage.

Comment by Christopher Zimmermann [ 14/May/13 ]

Review Recommendations:

WorkbenchPresenter - remove:
/**

  • TODO: Add JavaDoc for WorkbenchPresenter.
    */

Why is big block of code commented out in TreeViewImpl?

Generated at Mon Feb 12 08:42:32 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.