[MGNLUI-1026] Update location fragment during content app initialization. Created: 03/Apr/13  Updated: 10/Mar/21  Resolved: 10/Mar/21

Status: Closed
Project: Magnolia UI
Component/s: content app
Affects Version/s: 5.0
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Eric Hechinger Assignee: Unassigned
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: 5.5h
Time Spent: 2.5h
Original Estimate: 1d

Issue Links:
Relates
relates to MGNLUI-3717 BrowserLocation should treat null 'pa... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Story Points: 2

 Description   

During initialization of a content app, the location fragment is not refreshed.

The fragment contains the app name but not the location within the app itself, the view type etc.



 Comments   
Comment by Eric Hechinger [ 04/Apr/13 ]

Currently the Location is updated during initialisation in:
BrowserSubApp.restoreBrowser()
if (viewType == null)

{ viewType = getBrowser().getDefaultViewType(); location.updateViewType(viewType); getAppContext().setSubAppLocation(getSubAppContext(), location); }

but the fragment is not updated...

Comment by Ngoc Nguyenthanh [ 11/Dec/15 ]

Here is why the location fragment does not updated

  • From there: info.magnolia.ui.framework.app.AppInstanceControllerImpl:382. It start the sub-app without set value for currentSubAppContext
  • Then when the sub app need to be started at: info.magnolia.ui.framework.app.AppInstanceControllerImpl:426. It will call info.magnolia.ui.contentapp.browser.BrowserSubApp#start to start the browser subapp
  • Next at info.magnolia.ui.contentapp.browser.BrowserSubApp#restoreBrowser. The location need to be updated via getAppContext().updateSubAppLocation(getSubAppContext(), location);
  • The problem is in info.magnolia.ui.framework.app.AppInstanceControllerImpl#updateSubAppLocation : 474. It check getActiveSubAppContext() == subAppContext. The active sub-app context didn't set
    And it lead to the Shell can not update the URI : info.magnolia.ui.framework.shell.ShellImpl#setFragment
Generated at Mon Feb 12 08:42:38 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.