[MGNLUI-1087] Implement all button states according to the design Created: 11/Apr/13 Updated: 20/Nov/18 Resolved: 07/Jun/13 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | design, forms |
| Affects Version/s: | None |
| Fix Version/s: | 5.0 |
| Type: | Task | Priority: | Critical |
| Reporter: | Andreas Weder | Assignee: | Samuli Penttilä |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | design | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 1d 1.5h | ||
| Original Estimate: | Not Specified | ||
| Environment: |
magnolia-bundle_stable build #35 (2013-04-08 14:27:35) |
||
| Attachments: |
|
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoR: |
Empty
|
| Date of First Response: | |
| Sprint: | RC 1 |
| Description |
|
Please implement all changes and states of buttons as described below.
Please also make sure that buttons conform to the definition shown on the style guide, which I also attached to this issue.
See also http://wiki.magnolia-cms.com/display/UX/State+of+input+fields+in+forms (section on buttons). |
| Comments |
| Comment by Christopher Zimmermann [ 04/Jun/13 ] |
|
Test |
| Comment by Samuli Penttilä [ 07/Jun/13 ] |
|
Implemented hover and active states and increased button height to 23px. |
| Comment by Mikaël Geljić [ 07/Jun/13 ] |
|
Didn't fully complete review so far - currently adding a snippet to showcase app to test light dialogs. Meanwhile see those first comments:
|
| Comment by Andreas Weder [ 07/Jun/13 ] |
|
Actually, please do NOT move the label down. Just leave it in-place and make the button turn white on press. |
| Comment by Mikaël Geljić [ 07/Jun/13 ] |
|
Comments for buttons in LightDialogs:
You may now pull showcase-app module, I added a fourth tab for notifications/confirm dialog showcase. |
| Comment by Andreas Weder [ 07/Jun/13 ] |
|
Thanks for the ptr, Mikael: I'd say the button should remain as when pressed, if you move the mouse out. |
| Comment by Samuli Penttilä [ 10/Jun/13 ] |
|
Prevented style leaking to date/time pickers and fixed issues observed with light dialogs. |