[MGNLUI-111] workbench definition part of subapp descriptor, not app descriptor Created: 26/Oct/12  Updated: 11/Feb/13  Resolved: 27/Nov/12

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Task Priority: Neutral
Reporter: Espen Jervidalo Assignee: Espen Jervidalo
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLUI-228 AppBuilder vs ContentAppBuilder Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Comments   
Comment by Jan Haderka [ 26/Nov/12 ]
  • AppBuilder
         public SubAppBuilder subApp(String name) {
    
    +        ConfiguredContentSubAppDescriptor subAppDescriptor = new ConfiguredContentSubAppDescriptor();
    
    • does that mean we support only content app descriptors from AppBuilder?
    • Why is AppBuilder part of contacts app? Is it only ContactsAppBuilder rather then generic one? If so, it needs to be renamed.
  • ContentAppBuilder
    • what is the difference between AppBuilder and ContentAppBuilder now that both use Content?
    • Why is it in contacts package? If it is not generic, it needs to be renamed to ContactContentAppBuilder
  • SubAppBuilder
    -    public SubAppBuilder(ConfiguredSubAppDescriptor descriptor) {
    +    public SubAppBuilder(ConfiguredContentSubAppDescriptor descriptor) {
    
    • it is now just ContentSubAppBuilder and if it is not generic it needs to be renamed to ContactsSubAppBuilder. If it is generic, in needs to be moved out of contacts app module.
  • AppContext
         /**
          *
          * @param location
          */
    
    • This kind of javadoc is totally useless. If you don't plan to write any javadoc, don't leave this in the code.
Comment by Espen Jervidalo [ 27/Nov/12 ]

see MGNLUI-228

Generated at Mon Feb 12 08:33:42 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.