[MGNLUI-1118] Form - dynamic sizing Created: 16/Apr/13 Updated: 19/Jun/13 Resolved: 22/Apr/13 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | design |
| Affects Version/s: | 5.0 |
| Fix Version/s: | 5.0 |
| Type: | Bug | Priority: | Major |
| Reporter: | Samuli Penttilä | Assignee: | Samuli Penttilä |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Sprint: | Iteration 2013-16, Iteration 2013-17 | ||||||||
| Description |
|
Form - dynamic sizing (buttons get hidden) (at least review the complexity of implementation) |
| Comments |
| Comment by Samuli Penttilä [ 19/Apr/13 ] |
|
Most straightforward implementation is that a Dialog that contains the Form with Tabsheet scroller updates the height of the Dialog is able to expand to the contained Tabsheet scroller. Tabsheet scroller would then use this height minus fixed size components like dialog headers and footers. Going to implement this directly creates a dependency from BaseDialog to FormView which is not desired. |
| Comment by Samuli Penttilä [ 22/Apr/13 ] |
|
Implemented by hiding ugly implementation details in created DialogContainingForm class. |
| Comment by Christopher Zimmermann [ 24/Apr/13 ] |
|
Review: I recommend renaming FormView method setTabSheetMaxHeight() to setMaxHeight(). Its more descriptive, and also easier for someone to understand why it is there and what it does. Please take a look at why the bottom pixels below the buttons gets squished when page size is reduced - maybe some padding is missing from MaxSize calculation. Not a huge deal, and could be fixed later. |
| Comment by Samuli Penttilä [ 25/Apr/13 ] |
|
Added javadoc and renamed setTabSheetMaxSize method based on review. |