[MGNLUI-113] Unify views and their related containers Created: 29/Oct/12  Updated: 11/Feb/13  Resolved: 05/Nov/12

Status: Closed
Project: Magnolia UI
Component/s: content app
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Task Priority: Critical
Reporter: Daniel Lipp Assignee: Daniel Lipp
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File MGNLUI-113__inline_TreeModel_s_code_in_HierarchicalJcrContainer_.patch    
Issue Links:
causality
is causing MGNLDAM-8 Adapt container usage according to re... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty

 Description   

Current implementations are not streamlined at all:

  • ContentViewBuilderImpl#build should either create all containers or none - currently it's a mix- accessing jcr happens from various places although we could reuse logic: TreeModel, AbstractJcrContainer and LazyThumbnailViewImpl!
  • all AbstractJCRContainers require a TreeModel but only HierarchicalContianer should
  • TreeModel is a JcrContainerSource? Why not put that logic into HierachicalJcrContainer directly as it's only used there?


 Comments   
Comment by Daniel Lipp [ 29/Oct/12 ]

Did some research on how clean up of TreeModel would look like - here's the result.

Comment by Daniel Lipp [ 05/Nov/12 ]

One more thing to think about: IMHO the naming is confusing
TreeViewImpl -> HierarchicalJcrContainer
ListViewImpl -> FlatJcrContainer
SearchViewImpl -> SearchJcrContainer
LazyThumbnailViewImpl -> ThumbnailContainer

Comment by Daniel Lipp [ 19/Nov/12 ]

As JIRA cannot resolve commits for this ticket, here they are: https://git.magnolia-cms.com/gitweb/?p=magnolia_ui.git&a=search&h=HEAD&st=commit&s=MGNLUI-113

Generated at Mon Feb 12 08:33:43 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.