Implement Notifications and Indications (MGNLUI-1065)

[MGNLUI-1142] NotificationIndicator tidy up Created: 18/Apr/13  Updated: 19/Apr/13  Resolved: 18/Apr/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 5.0

Type: Sub-task Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MGNLUI-1102 Notification component Closed
Template:
Date of First Response:
Sprint: Iteration 2013-14, Iteration 2013-15, Iteration 2013-16

 Description   

Rename to Notification
Eliminate done event.

Update helper menthods to:
OverlayCloser openNotification(MessageStyleType type, int timeout_msec, View viewToShow);
OverlayCloser openNotification(MessageStyleType type, int timeout_msec, String title);

Add
OverlayCloser openNotification(MessageStyleType type, int timeout_msec, String title, String linkText, NotificationCallback cb);

NotificationCallback is for when users click on the link.



 Comments   
Comment by Magnolia International [ 18/Apr/13 ]

Actually, there's a little something that bugs me:
In info.magnolia.ui.vaadin.overlay.BaseOverlayLayer#openNotification

                String linkTextBrackets = "[" + linkText + "]";

Shouldn't we just use some CSS style to highlight/surround the link, instead of hardcoding square brackets in there ? (And if we really want square brackets, I assume this would be reproducible with :before and :after pseudo-selectors?)

Comment by Christopher Zimmermann [ 19/Apr/13 ]

Good idea.
I kept the brackets as that is what is specified, but took out the hardcoded brackets and used the css technique.

Generated at Mon Feb 12 08:43:45 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.