[MGNLUI-1191] Base actions should be in contentapp module and should have consistent class naming Created: 24/Apr/13  Updated: 26/Jun/13  Resolved: 26/Jun/13

Status: Closed
Project: Magnolia UI
Component/s: forms, framework
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Improvement Priority: Neutral
Reporter: Christian Ringele Assignee: Unassigned
Resolution: Won't Fix Votes: 0
Labels: actions
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Screen Shot 2013-04-24 at 14.30.56 .png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Creating a content app by the tutorial and analyzing the configuration of the actions i saw these to action classes:
[1] info.magnolia.ui.contentapp.detail.action.CreateItemActionDefinition
[2] info.magnolia.ui.app.contacts.action.AddFolderActionDefinition

Naming inconsistency:
Either create or add for both classes, preferably create.

Location:
Creating a folder should be prided by the contentapp module and not by the contacts module.



 Comments   
Comment by Tobias Mattsson [ 29/Apr/13 ]

Actually, ideally we'd have a set of actions that were reusable across apps, by content apps and regular apps alike.

Comment by Tobias Mattsson [ 26/Jun/13 ]

Base actions are in ui-framework, only those specific for content apps are in the content app module.

Generated at Mon Feb 12 08:44:13 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.