[MGNLUI-1205] As a user I am notified if working with the activation (also with workflow) so that I am guided through the process. Created: 25/Apr/13  Updated: 30/Apr/13  Resolved: 29/Apr/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Story Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLWORKFLOW-60 Pulse Subapp: Display success and err... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: Workflow
Sprint: Iteration 2013-17

 Description   

Pages App

  • When user clicks Publish:
    • Direct activation: Show notification.
    • Workflow launched: Show notification, different message.
  • When user clicks UnPublish
    • Direct de-activation: Show notification.
    • Workflow launched: Show notification, different message.

Update pages app bootstraps to implement deactivation.

Action classes and tests will require an injected SubAppContext parameter to display the notification.



 Comments   
Comment by Daniel Lipp [ 27/Apr/13 ]

Current implementation of ActivationActionDefinition#workflowInstalled results in error stacktrace in case workflow is not installed (ce-bundle).
That's why the de-bundle-with-selenium is currently failing - crawling reveals that stack trace. The impl should be changed to check for existence of that path, renamed to isWorkflowInstalled and ideally moved to a different class.

[INFO] [talledLocalContainer] 2013-04-27 22:50:06,121 ERROR info.magnolia.jcr.util.SessionUtil                : Exception during node Search for nodePath: '/modules/workflow-base' in repository: 'config'
[INFO] [talledLocalContainer] javax.jcr.PathNotFoundException: /modules/workflow-base
[INFO] [talledLocalContainer] 	at org.apache.jackrabbit.core.ItemManager.getNode(ItemManager.java:577)
[INFO] [talledLocalContainer] 	at org.apache.jackrabbit.core.session.SessionItemOperation$6.perform(SessionItemOperation.java:129)
[INFO] [talledLocalContainer] 	at org.apache.jackrabbit.core.session.SessionItemOperation$6.perform(SessionItemOperation.java:125)
[INFO] [talledLocalContainer] 	at org.apache.jackrabbit.core.session.SessionItemOperation.perform(SessionItemOperation.java:187)
[INFO] [talledLocalContainer] 	at org.apache.jackrabbit.core.session.SessionState.perform(SessionState.java:216)
[INFO] [talledLocalContainer] 	at org.apache.jackrabbit.core.SessionImpl.perform(SessionImpl.java:361)
[INFO] [talledLocalContainer] 	at org.apache.jackrabbit.core.SessionImpl.getNode(SessionImpl.java:1109)
[INFO] [talledLocalContainer] 	at info.magnolia.jcr.wrapper.DelegateSessionWrapper.getNode(DelegateSessionWrapper.java:179)
[INFO] [talledLocalContainer] 	at info.magnolia.jcr.wrapper.DelegateSessionWrapper.getNode(DelegateSessionWrapper.java:179)
[INFO] [talledLocalContainer] 	at info.magnolia.jcr.wrapper.NodeWrappingDelegateSessionWrapper.getNode(NodeWrappingDelegateSessionWrapper.java:55)
[INFO] [talledLocalContainer] 	at info.magnolia.jcr.util.SessionUtil.getNode(SessionUtil.java:76)
[INFO] [talledLocalContainer] 	at info.magnolia.ui.admincentral.activation.action.ActivationActionDefinition.workflowInstalled(ActivationActionDefinition.java:79)
[INFO] [talledLocalContainer] 	at info.magnolia.ui.admincentral.activation.action.ActivationActionDefinition.getSuccessMessage(ActivationActionDefinition.java:61)
[INFO] [talledLocalContainer] 	at info.magnolia.ui.admincentral.activation.action.ActivationAction.onPostExecute(ActivationAction.java:98)
Comment by Christopher Zimmermann [ 29/Apr/13 ]

Renamed workflowInstalled to isWorkflowInstalled.
isWorkflowInstalled now implemented with ModuleRegistry.
Added @Override to message methods.

Generated at Mon Feb 12 08:44:21 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.