[MGNLUI-1290] Rename abstract action base classes and relocate action classes Created: 02/May/13  Updated: 04/Jun/13  Resolved: 27/May/13

Status: Closed
Project: Magnolia UI
Component/s: framework
Affects Version/s: None
Fix Version/s: 5.0

Type: Task Priority: Major
Reporter: Tobias Mattsson Assignee: Daniel Lipp
Resolution: Fixed Votes: 0
Labels: actions
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing CNTCTSAPP-17 Adapt to renaming and relocation of a... Closed
is causing MGNLDAM-231 Adapt to renaming abstract action bas... Closed
is causing MGNLWORKFLOW-62 Adapt to renaming and relocation of a... Closed
duplicate
is duplicated by MGNLUI-695 Move common content actions to ui-fra... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Sprint: Beta 3

 Description   
  • ActionBase should be renamed to AbstractAction
  • RepositoryOperationAction should be renamed to AbstractRepositoryAction
  • CommandActionBase should be renamed to AbstractCommandAction
  • CommandActionBase should be moved from info.magnolia.ui.framework.app.action to be in the same package as AbstractRepositoryAction
  • ActivationAction, DeactivationAction and their definition classes should be moved from info.magnolia.ui.admincentral.activation.action to info.magnolia.ui.framework.action
  • The classes in info.magnolia.ui.admincentral.tree.action should be moved to info.magnolia.ui.framework.action
  • The actions CreateDialogAction, EditDialogAction and their definition classes in info.magnolia.ui.admincentral.dialog.action should move to info.magnolia.ui.framework.action

Also make sure all tests are moved as well.

Also, it could make sense to rename CreateDialogAction and EditDialogAction, to OpenCreateDialogAction and OpenEditDialogAction

We also need to update documentation. We won't change dependencies for now although from a maven perspective depending on ui.framework would be enough for some modules now. The problem is that ui.framework is not a magnolia module so we couldn't adapt the module dependencies accordingly.



 Comments   
Comment by Daniel Lipp [ 27/May/13 ]

Detailed list of the changes e.g. for documentation:

Old New
info.magnolia.ui.api.action.ActionBase info.magnolia.ui.api.action.AbstractAction
info.magnolia.ui.admincentral.tree.action.RepositoryOperationAction info.magnolia.ui.framework.action.AbstractRepositoryAction
info.magnolia.ui.framework.app.action.CommandActionBase info.magnolia.ui.framework.action.AbstractActionBase
info.magnolia.ui.admincentral.tree.action.* info.magnolia.ui.framework.action.*
info.magnolia.ui.admincentral.activation.action.ActivationAction info.magnolia.ui.framework.action.ActivationAction
info.magnolia.ui.admincentral.activation.action.ActivationActionDefinition info.magnolia.ui.framework.action.ActivationActionDefinition
info.magnolia.ui.admincentral.activation.action.DeactivationAction info.magnolia.ui.framework.action.DeactivationAction
info.magnolia.ui.admincentral.activation.action.DeactivationActionDefinition info.magnolia.ui.framework.action.DeactivationActionDefinition
info.magnolia.ui.admincentral.dialog.action.CreateDialogAction info.magnolia.ui.framework.action.OpenCreateDialogAction
info.magnolia.ui.admincentral.dialog.action.CreateDialogActionDefinition info.magnolia.ui.framework.action.OpenCreateDialogActionDefinition
info.magnolia.ui.admincentral.dialog.action.EditDialogAction info.magnolia.ui.framework.action.OpenEditDialogAction
info.magnolia.ui.admincentral.dialog.action.EditDialogActionDefinition info.magnolia.ui.framework.action.OpenEditDialogActionDefinition
Generated at Mon Feb 12 08:45:09 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.