[MGNLUI-1296] In all lists, add a new column "path" showing the path to the item contained in the row Created: 02/May/13 Updated: 03/Jun/13 Resolved: 30/May/13 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | design, tree/list |
| Affects Version/s: | None |
| Fix Version/s: | 5.0 |
| Type: | Story | Priority: | Critical |
| Reporter: | Andreas Weder | Assignee: | Christopher Zimmermann |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | usability | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Date of First Response: | |||||||||||||
| Sprint: | Beta 3 | ||||||||||||
| Description |
|
Reviewer - please discuss with CLZ first. only review top 2 commits (on contentview-columns branch). Only in lists and the list of search results, add a new column containing the path to the item. We need the path in lists in order to distinguish two items with the same name. It's not enough to just have the breadcrumb, as it always requires you to select an entry first before you know where exactly it's located.
|
| Comments |
| Comment by Christopher Zimmermann [ 07/May/13 ] |
|
Could be useful for the elipses: |
| Comment by Christopher Zimmermann [ 07/May/13 ] |
|
Otherwise - use CSS3 for an end ellipses: |
| Comment by Christopher Zimmermann [ 07/May/13 ] |
|
If implementation of middle ellipses is too difficult - what about an html "title" attribute to get a tooltip of the full path after a short delay on the path? |
| Comment by Samuli Penttilä [ 10/May/13 ] |
|
We go for CSS3 end ellipses for now but one possible improvement would be an idea that we add ellipses statically so that we always show begin and end of path. In this way it's not dotting dynamically based on space available. For example if we use first and last leaf in JCR node tree: /modules/data/dialogs/RssAggregator/mainTab/filters/options-properties/property3 becomes /modules/../options-properties/property3 |
| Comment by Christopher Zimmermann [ 10/May/13 ] |
|
Good news: It works! Bad news: Too inflexible. I think developers/admins should always have the ability to configure existance and order of columns, rather then having them hardcoded. |
| Comment by Samuli Penttilä [ 13/May/13 ] |
|
Another possible solution is to make path column configurable by a property. As we want it to show up only in the list view's second column it would be confusing to define it as a configurable column. More natural way is to create boolean property for workbench definition like "disablePathColumn=true|false" which would allow it to be hidden on demand. One thing about current implementation is that it uses itemId.toString() to get the path. Ticket |
| Comment by Christopher Zimmermann [ 13/May/13 ] |
|
Feedback from ScrumOfScrums and Philipp: |
| Comment by Andreas Weder [ 23/May/13 ] |
|
I really think we need this - search is just not complete without this. There's a workaround in search results to click on an item in order to see where it's located (you see its breadcrumb), but having the path in lists (and only lists) allows you to also sort by path. |
| Comment by Christopher Zimmermann [ 30/May/13 ] |
|
Implemented based on decisions from Architecture group, that columns move to the content views. Implementation:
A bit silly that both classes have this same method. Suggestions from reviewer? |
| Comment by Federico Grilli [ 30/May/13 ] |
|
Some remarks after reviewing the issue: info.magnolia.ui.workbench.container.AbstractJcrContainer.getColumnsIterator() |