[MGNLUI-1393] ActivationActionDefinition and DeactivationActionDefinition has hardcoded error strings and makes ugly tests to see if workflow module is installed Created: 20/May/13 Updated: 12/Jun/13 Resolved: 10/Jun/13 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | framework |
| Affects Version/s: | None |
| Fix Version/s: | 5.0 |
| Type: | Bug | Priority: | Major |
| Reporter: | Tobias Mattsson | Assignee: | Jozef Chocholacek |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | actions | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: | |
| Sprint: | Beta 3, RC 1 |
| Description |
|
The messages should be configurable and the tests needs to be in the action instead |
| Comments |
| Comment by Tobias Mattsson [ 30/May/13 ] |
|
Add the check for testing if the workflow module is installed in the action and introduce extra error and success messages in the definitions to be used when the module is installed. |
| Comment by Tobias Mattsson [ 04/Jun/13 ] |
|
I can't find any messages for the new keys. There should be a tests that verifies the correct message is used, one test with and one without workflow installed. Also move the messages til after the #MAGNOLIA 5.0 comment. |
| Comment by Tobias Mattsson [ 11/Jun/13 ] |
|
We don't want to add a message bundle in ui-frameowork called info.magnolia.ui.admincentral.messages Add the keys in admincentral for now. |
| Comment by Jozef Chocholacek [ 11/Jun/13 ] |
|
The bundle is in tests, I didn't want to touch too much projects. |