Create a multiselect field (MGNLUI-1449)

[MGNLUI-1453] Create a MultiLinkField Created: 28/May/13  Updated: 25/Jun/13  Resolved: 05/Jun/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Sub-task Priority: Neutral
Reporter: Eric Hechinger Assignee: Eric Hechinger
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLUI-1458 AbstractJcrNodeAdapter adds nodes to ... Closed
Template:
Date of First Response:
Sprint: Beta 3

 Description   

Create a MultiLinkField (Set of LinkField), his builder and definition.



 Comments   
Comment by Tobias Mattsson [ 04/Jun/13 ]

MultiLinkFieldBuilder

  • mentions MultiPropertyDelegate in comment
  • unnecessary cast on line 100

MultiLinkFieldDefinition

  • is it necessary to always configure a class? can't we have a property with simple string values and a class that takes precedence if set?
  • spelling error imput should be input
  • convert comments on fields to javadoc comments on getters

MultiLinkField

  • add documentation on what the "tmp" and "transientPathProperty" mean
  • spelling error on createSelectCompoment should be createSelectComponent, or maybe createEntryComponent ?
  • the order is not preserved, if you add something at the end of the list and the open the dialog again the new entries appear first, possibly caused by MGNLUI-1458, see if this is the case

MultiLinkFieldBuilderTest

  • should have copyright year 2013, unless it was started in 2012 already
Comment by Eric Hechinger [ 05/Jun/13 ]

MultiLinkFieldBuilder

mentions MultiPropertyDelegate in comment
unnecessary cast on line 100
(ehe: agree)

MultiLinkFieldDefinition

is it necessary to always configure a class? can't we have a property with simple string values and a class that takes precedence if set?
(ehe: this is currently done in the MultiLinkFieldBuilder. If no saveNodeType is define, the SingleValueHandler is then used)
spelling error imput should be input
convert comments on fields to javadoc comments on getters

MultiLinkField

add documentation on what the "tmp" and "transientPathProperty" mean
(ehe: bulk copy... not needed for multilinkSelect.)
spelling error on createSelectCompoment should be createSelectComponent, or maybe createEntryComponent ?
the order is not preserved, if you add something at the end of the list and the open the dialog again the new entries appear first, possibly caused by MGNLUI-1458, see if this is the case
(ehe: after investigation, seems to be related to this ticket:
In SubNodesValueHandler.setValue(), newValue is a,b,c, after the iteration of the list and creation of the subItem,
the childItem as the following children b,c,a)

MultiLinkFieldBuilderTest

should have copyright year 2013, unless it was started in 2012 already

Generated at Mon Feb 12 08:46:44 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.